Symfony 4 support #13
Conversation
|
Hmm looks like the Symfony CMF testing package needs SF4 support too. Not sure about the memory issue on Then it seems that we use a deprecated Doctrine ORM method - that would need to be looked at (but may well be in the CMF testing). Also happy to drop the CMF testing dep if possible. |
|
@dantleech symfony-cmf/testing 2.1.0-RC1 should work with symfony 4.0. will work on this PR after phpcr/phpcr-migrations#8 is merged. |
chirimoya
force-pushed
the
symfony-4-support
branch
4 times, most recently
from
801f313 to
9db3197
Compare
chirimoya
force-pushed
the
symfony-4-support
branch
9 times, most recently
from
dfb8e7b to
1b11d6f
Compare
chirimoya
force-pushed
the
symfony-4-support
branch
from
1b11d6f to
e154e48
Compare
chirimoya
force-pushed
the
symfony-4-support
branch
from
e154e48 to
cc79d4e
Compare
|
@dantleech can you have a look? tests are green now. |
|
Do you guys want to maintain? |
|
@dantleech I guess we need to ;-) Can you add @wachterjohannes and @alexander-schranz as maintainer and maybe you find time to tag an new release. That would be awesome. |
|
Does this bundle still support 7.0? if so we should add that to travis, if not we should add it as a minimum requirement in |
|
Added @wachterjohannes and @alexander-schranz as collaborators (@chirimoya already has push access) |
| <argument type="service" id="phpcr_migrations.version_storage" /> | ||
| <argument type="service" id="phpcr_migrations.version_finder" /> | ||
| <tag name="console.command" /> | ||
| </service> | ||
|
|
||
| <service id="phpcr_migrations.command.migrate" class="DTL\Bundle\PhpcrMigrations\Command\MigrateCommand"> | ||
| <service id="phpcr_migrations.command.migrate" class="DTL\Bundle\PhpcrMigrations\Command\MigrateCommand" public="true"> |
There was a problem hiding this comment.
no, but for symfony 4.0 you need to define the public services
phpcr/phpcr-migrations#8
symfony-cmf/Testing#179