Skip to content

Fix for #127, 'escape' the selectorName #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2014
Merged

Fix for #127, 'escape' the selectorName #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions tests/06_Query/QuerySql2OperationsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ public function testLengthOperandOnEmptyProperty()
SELECT data.*
FROM [nt:unstructured] AS data
WHERE
data.empty-value IS NOT NULL
AND LENGTH(data.empty-value) < 1
data.[empty-value] IS NOT NULL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the - is a special character too? did you test that with jackrabbit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when I ran the tests locally it errored over this query as well.

AND LENGTH(data.[empty-value]) < 1
AND ISDESCENDANTNODE([/tests_general_base])
',
QueryInterface::JCR_SQL2
Expand All @@ -406,8 +406,8 @@ public function testLengthOperandOnEmptyProperty()
SELECT data.*
FROM [nt:unstructured] AS data
WHERE
data.empty-value IS NOT NULL
AND LENGTH(data.empty-value) = 0
data.[empty-value] IS NOT NULL
AND LENGTH(data.[empty-value]) = 0
AND ISDESCENDANTNODE([/tests_general_base])
',
QueryInterface::JCR_SQL2
Expand All @@ -426,8 +426,8 @@ public function testLengthOperandOnEmptyProperty()
SELECT data.*
FROM [nt:unstructured] AS data
WHERE
data.empty-value IS NOT NULL
AND LENGTH(data.empty-value) > -1
data.[empty-value] IS NOT NULL
AND LENGTH(data.[empty-value]) > -1
AND ISDESCENDANTNODE([/tests_general_base])
',
QueryInterface::JCR_SQL2
Expand All @@ -448,7 +448,7 @@ public function testLengthOperandOnBinaryProperty()
$query = $this->sharedFixture['qm']->createQuery('
SELECT data.*
FROM [nt:unstructured] AS data
WHERE LENGTH(data.jcr:data) = 121
WHERE LENGTH(data.[jcr:data]) = 121
AND ISDESCENDANTNODE([/tests_general_base])
',
QueryInterface::JCR_SQL2
Expand Down