Fix for #127, 'escape' the selectorName #128
Conversation
|
should we be worried that jackalope-doctrine-dbal did work even without this fix? it would let people write invalid things and then be confused when trying to switch to jackalope-jackrabbit. should we open an issue on jackalope-doctrine-dbal to refuse names that are not escaped? |
| @@ -386,8 +386,8 @@ public function testLengthOperandOnEmptyProperty() | |||
| SELECT data.* | |||
| FROM [nt:unstructured] AS data | |||
| WHERE | |||
| data.empty-value IS NOT NULL | |||
| AND LENGTH(data.empty-value) < 1 | |||
| data.[empty-value] IS NOT NULL | |||
There was a problem hiding this comment.
so the - is a special character too? did you test that with jackrabbit?
There was a problem hiding this comment.
Yeah, when I ran the tests locally it errored over this query as well.
|
Not sure, I couldn't actually find a list with special tokens for this. In JSR-283 they don't mention the brackets for every operand. |
Fix for #127, 'escape' the selectorName
|
created phpcr/phpcr-utils#101 |
|
thanks a lot @wjzijderveld ! |
Need to escape selectorNames with specials tokens in it.
Jackalope Doctrine DBAL seems happy with this change.