Skip to content

Enhancement: Require and use PHP 8.2 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Enhancement: Require and use PHP 8.2 #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfdc272
Enhancement: Require and use PHP 8.2
localheinz Nov 29, 2023
b71ed70
Fix: Set PHP_CS_FIXER_IGNORE_ENV environment variable
localheinz Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/integrate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "8.2"

steps:
- name: "Checkout"
Expand Down Expand Up @@ -51,6 +51,8 @@ jobs:

- name: "Run friendsofphp/php-cs-fixer"
run: "vendor/bin/php-cs-fixer fix --ansi --config=.php-cs-fixer.php --diff --dry-run --verbose"
env:
PHP_CS_FIXER_IGNORE_ENV: "1"
Comment on lines +54 to +55
Copy link
Contributor Author

@localheinz localheinz Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update friendsofphp/php-cs-fixer in a separate pull request.

For reference, see https://github.com/php/web-php/actions/runs/7031918087/job/19134541998#step:9:12.


tests:
name: "Tests"
Expand All @@ -60,7 +62,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.3"
- "8.2"

steps:
- name: "Checkout"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ https://wiki.php.net/web/mirror

## Code requirements

Code must function on a vanilla PHP 7.3 installation.
Code must function on a vanilla PHP 8.2 installation.
Please keep this in mind before filing a pull request.

## Contributing
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"source": "https://github.com/php/web-php"
},
"require": {
"php": "^7.3"
"php": "~8.2.0"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.4.0"
Expand All @@ -20,7 +20,7 @@
},
"config": {
"platform": {
"php": "7.3.19"
"php": "8.2.0"
},
"sort-packages": true
}
Expand Down
8 changes: 4 additions & 4 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.