Enhancement: Require and use PHP 8.2 #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/php82
branch
from
4b55241 to
bfdc272
Compare
localheinz
changed the title
localheinz
commented
Nov 29, 2023
Comment on lines
+54
to
+55
| env: | ||
| PHP_CS_FIXER_IGNORE_ENV: "1" |
There was a problem hiding this comment.
We can update friendsofphp/php-cs-fixer in a separate pull request.
For reference, see https://github.com/php/web-php/actions/runs/7031918087/job/19134541998#step:9:12.
|
How do we know whether the code can actually run with 8.2 without issues? It's not like we have tests for most of the site. |
|
Which version does the website currently use in production? See https://twitter.com/pronskiy/status/1729819209553641860: 
|
|
Hm.. I'm assuming it's already 8.2 in the production host now, isn't it? |
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
💁♂️ According to @pronskiy, the website currently runs on PHP 8.2.