[FFI] Track unsized types #9642
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| --TEST-- | ||
| Disallow instantiation of unsized types | ||
| --EXTENSIONS-- | ||
| ffi | ||
| --INI-- | ||
| ffi.enable=1 | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| function test(string $type) { | ||
| echo $type . ': '; | ||
| try { | ||
| FFI::new($type); | ||
| echo 'sized'; | ||
| } catch (Throwable $e) { | ||
| echo $e->getMessage(); | ||
| } | ||
| echo "\n"; | ||
| } | ||
|
|
||
| test('char[0]'); | ||
| test('char[1]'); | ||
| test('char*'); | ||
| test('struct {}'); | ||
| test('struct {}*'); | ||
| test('struct {int32_t length; char data[];}'); | ||
| test('struct {int32_t length; char data[0];}'); | ||
| test('union {}'); | ||
| test('union {}*'); | ||
| test('enum { FOO }'); | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| char[0]: Cannot instantiate FFI\CData of zero size | ||
| char[1]: sized | ||
| char*: sized | ||
| struct {}: Cannot instantiate FFI\CData of zero size | ||
| struct {}*: sized | ||
| struct {int32_t length; char data[];}: Cannot instantiate FFI\CData of unsized type | ||
| struct {int32_t length; char data[0];}: Cannot instantiate FFI\CData of unsized type | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. I agree
|
||
| union {}: Cannot instantiate FFI\CData of zero size | ||
| union {}*: sized | ||
| enum { FOO }: sized | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't introduce new field. Use ZEND_FFI_ATTR_INCOMPLETE_ARRAY and ZEND_FFI_ATTR_VLA attribute. Or add a new attribute ZEND_FFI_ATTR_UNKNOWN_SIZE (may be with a better name).