[FFI] Track unsized types #9642
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids surprises when creating instances of types like
struct { char[] foo }
mvorisek
reviewed
Oct 7, 2022
| struct {}: Cannot instantiate FFI\CData of zero size | ||
| struct {}*: sized | ||
| struct {int32_t length; char data[];}: Cannot instantiate FFI\CData of unsized type | ||
| struct {int32_t length; char data[0];}: Cannot instantiate FFI\CData of unsized type |
There was a problem hiding this comment.
-
test with 1 will be good here too
-
why unsized, shouldn't this ex warn about zero size?
There was a problem hiding this comment.
I agree
- Cannot instantiate FFI\CData of type "void"
- Cannot instantiate FFI\CData of type with variable size
- I don't think zero size arrays should be disallowed
|
@dstogov Do you think this adds any value? If not, feel free to close this PR. |
dstogov
requested changes
Oct 24, 2022
| ffi_abi abi; | ||
| } func; | ||
| }; | ||
| bool sized; |
There was a problem hiding this comment.
Please don't introduce new field. Use ZEND_FFI_ATTR_INCOMPLETE_ARRAY and ZEND_FFI_ATTR_VLA attribute. Or add a new attribute ZEND_FFI_ATTR_UNKNOWN_SIZE (may be with a better name).
| struct {}: Cannot instantiate FFI\CData of zero size | ||
| struct {}*: sized | ||
| struct {int32_t length; char data[];}: Cannot instantiate FFI\CData of unsized type | ||
| struct {int32_t length; char data[0];}: Cannot instantiate FFI\CData of unsized type |
There was a problem hiding this comment.
I agree
- Cannot instantiate FFI\CData of type "void"
- Cannot instantiate FFI\CData of type with variable size
- I don't think zero size arrays should be disallowed
|
I'm not currently interested in working on FFI, so I'm closing this. Anyone else is free to take over if they wish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids surprises when trying to create instances of structs that use the struct hack.
Got the idea from looking at #7949. Not sure if it makes sense.