Skip to content

Conversation

@phansys
Copy link
Contributor

@phansys phansys commented Dec 10, 2023

No description provided.

@phansys phansys marked this pull request as ready for review December 10, 2023 22:59
@phansys phansys requested a review from bukka as a code owner December 10, 2023 22:59
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot do this, as internal functions must treat any reference parameter as mixed with ZPP and do manual type checking. So this change just as is is incorrect.

@kocsismate
Copy link
Member

Yeah, I'm closing the PR because it's not possible to declare these parameters indeed as Gine said, since no parameter type check is performed at the start of the function. Adding support for In/out parameters would be needed in order to be able to declare the type of such parameters.

@kocsismate kocsismate closed this Dec 13, 2023
@phansys phansys deleted the stream_user_filter_stub branch December 14, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants