Add type declaration for argument 3 in php_user_filter::filter()
#1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
php_user_filter
branch
from
3d6f82d to
024c57b
Compare
phansys
force-pushed
the
php_user_filter
branch
from
024c57b to
b2ba29a
Compare
|
The type should be specified in the signature only if it is the same in the php-src. Unfortunately, I can't accept these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW, I don't know if this change should be provided through
LanguageLevelTypeAware, as I am not aware when this type was defined.See: php/php-src#12924 (review).