Fix phpGH-12763: PGSQL pg_untrace(): Argument #1 ($connection) must be of type resource or null, PgSql\Connection given. #12796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t be of type resource or null, PgSql\Connection given.
…t be of type resource or null, PgSql\Connection given. Add test bugGH12763.phpt
nielsdos
reviewed
Nov 27, 2023
| @@ -0,0 +1,23 @@ | |||
| --TEST-- | |||
| Bug #GH12763 (pg_untrace(): Argument #1 ($connection) must be of type resource or null, PgSql\Connection given) | |||
There was a problem hiding this comment.
Nit: for GitHub bugs, use the gh12763.php as filename. Similarly the title should be GH-12763 (pg_untrace(): ...)
For bugs on the old bugtracker we use Bug #xxxxx title and bugxxxxx.phpt filename.
ext/pgsql/tests/bugGH12763.phpt
Outdated
|
|
||
| ?> | ||
| --EXPECT-- | ||
| OK No newline at end of file |
There was a problem hiding this comment.
Please include a newline at the end of phpt files.
|
Just advice for next time, do not pick releases branch such as 8.1.26, instead if you target 8.1 pick PHP-8.1. |
…t be of type resource or null, PgSql\Connection given. Rename test to gh12763.phpt. Add new line.
That s fine we merge up usually anyway :) |
devnexen
approved these changes
Nov 27, 2023
|
Merged via 3f57bd80. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12764
As requested, I did it for branch 8.1