Fix phpGH-12763: PGSQL pg_untrace(): Argument #1 ($connection) must be of type resource or null, PgSql\Connection given. #12764
Conversation
|
Nice. Would you be able to add/modify a test please ? |
|
as far as I know, the fix ought to apply from master |
ext/pgsql/tests/bugGH12763.phpt
Outdated
|
|
||
| $conn = pg_connect($conn_str); | ||
|
|
||
| pg_untrace($conn); |
There was a problem hiding this comment.
file being named 'gh12763.phpt' should be good enough. I would like to see a bit more than this, involving pg_trace at least.
|
Couple of things :
|
|
Why is 8.3 not the proper branch? |
8.3.0 |
|
Sorry, I pushed approve a bit too early. The PR should target the PHP-8.2 branch, shouldn't it? |
Not PHP-8.3.0 for sure but I hesitate to consider it as fix rather than change of behavior, e.g. his test fails on windows. |
It's definitely a fix for a serious bug which I introduced in PHP 8.1 when I converted the resource to object. I don't really know what the trace file contains exactly, but I guess the test failure happens because of some diff between UNIX vs Windows, not due to the change itself. |
|
oh I see ... then let's target lower branches. |
degtyaryov
force-pushed
the
PHP-8.3.0
branch
from
2ee4827 to
f35a22a
Compare
4 participants
No description provided.