fix(extgen): correctly handle const blocks to declare iota constants#2086
Merged
alexandre-daubois merged 1 commit intophp:mainfrom Jan 12, 2026
Merged
fix(extgen): correctly handle const blocks to declare iota constants#2086alexandre-daubois merged 1 commit intophp:mainfrom
alexandre-daubois merged 1 commit intophp:mainfrom
Conversation
alexandre-daubois
force-pushed
the
const-block
branch
2 times, most recently
from
6cc05c2 to
166e57a
Compare
AlliBalliBaba
approved these changes
Dec 28, 2025
alexandre-daubois
force-pushed
the
const-block
branch
from
166e57a to
73c624e
Compare
dunglas
approved these changes
Jan 12, 2026
alexandre-daubois
force-pushed
the
const-block
branch
from
73c624e to
8f6075a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While continuing the work on #2011, I realized that constant declarations have a problem when using
iota. I mean, it technically works, but const blocks we not supported which means that setting all constants toiotaas shown in the documentation was non-sensical, asiotaresets every time outside of const blocks.So, this is between the bug fix and the feature. To me, it's a bug fix as the behavior wasn't the one intended when creating extgen.