feat(extgen): make the generator idempotent and avoid touching the original source#2011
Open
alexandre-daubois wants to merge 2 commits intophp:mainfrom
Open
feat(extgen): make the generator idempotent and avoid touching the original source#2011alexandre-daubois wants to merge 2 commits intophp:mainfrom
alexandre-daubois wants to merge 2 commits intophp:mainfrom
Conversation
alexandre-daubois
force-pushed
the
extgen-idempotent
branch
from
2caf932 to
0672f92
Compare
dunglas
requested changes
Dec 1, 2025
alexandre-daubois
force-pushed
the
extgen-idempotent
branch
from
0672f92 to
b6a1b3e
Compare
Member
Author
|
Requires #2086 to be merged first |
alexandre-daubois
force-pushed
the
extgen-idempotent
branch
2 times, most recently
from
b482106 to
30b21c9
Compare
alexandre-daubois
added a commit
that referenced
this pull request
Jan 12, 2026
…2086) While continuing the work on #2011, I realized that constant declarations have a problem when using `iota`. I mean, it technically works, but const *blocks* we not supported which means that setting all constants to `iota` as shown in the documentation was non-sensical, as `iota` resets every time outside of const blocks. So, this is between the bug fix and the feature. To me, it's a bug fix as the behavior wasn't the one intended when creating extgen.
alexandre-daubois
force-pushed
the
extgen-idempotent
branch
from
30b21c9 to
e5dbf66
Compare
alexandre-daubois
force-pushed
the
extgen-idempotent
branch
3 times, most recently
from
37773fb to
fbf79f1
Compare
Member
Author
|
Finally found the culprit for PHP 8.3 failures. For the record, All green now, ready for a new round of review @php/frankenphp-collaborators 🙂 |
alexandre-daubois
force-pushed
the
extgen-idempotent
branch
from
bf7eed3 to
577511e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DX is currently not optimal as we need to touch and edit the original source file. It is still in WIP, but this PR aims to improve a lot the DX of the extension generator by making it idempotent.
The proposed approach is to generate a wrapper to the original source file that will call it and then make the bindings to C. The original Go source will remain untouched and the generator can be run multiple times easily.
This also adds a header comment to all generated files (C file, C headers et al.):