Skip to content

drivers/imx-enet: Add support for ethernet in imxrt1170-evkb #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

julianuziemblo
Copy link

@julianuziemblo julianuziemblo commented Dec 9, 2024

Description

Add Ethernet support for iMX RT106x, merging the code with existing driver for iMX RT6UL/6ULL in drivers/imx-enet.c
IMPORTANT: this PR is a branch from #96

Motivation and Context

JIRA: RTOS-963
This PR is not this big by itself - it contains changes from (#96).

Checks for target armv7a7-imx6ull-evk will not be passing because of the changes to handling the plo init script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

Enet init script now is required to include the PHY model used, which is needed when the same board contains multiple enet devices with different PHYs. More info: phoenix-rtos/phoenix-rtos-project#1247

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

github-actions bot commented Dec 9, 2024

Unit Test Results

7 958 tests  ±0   7 432 ✅  - 2   41m 5s ⏱️ +44s
  470 suites ±0     524 💤 ±0 
    1 files   ±0       2 ❌ +2 

For more details on these failures, see this check.

Results for commit f8d05f5. ± Comparison against base commit 6622c68.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1170-evkb branch from b3c7e8b to 20981d2 Compare December 10, 2024 10:33
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1170-evkb branch from 20981d2 to 2318828 Compare February 3, 2025 14:47
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1170-evkb branch 2 times, most recently from 1fe706a to e7502d9 Compare February 4, 2025 11:34
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1170-evkb branch from e7502d9 to 4c12eaf Compare February 11, 2025 11:00
@Darchiv Darchiv requested a review from ziemleszcz March 11, 2025 09:49
MISRA compliance, replace magic numbers with
enums/defines, handle return values, etc.

JIRA: RTOS-507
refactor printfs with repeated format pattern into ephy_printf

JIRA: RTOS-507
add ephy_debug_printf toggled by EPHY_DEBUG
inside drivers/ephy.c and add debug prints
for easier debugging

JIRA: RTOS-507
first step to add separate implementation files for imx6ull and imxrt106x gpio

JIRA: RTOS-507
remove active value inversion in gpio_wait because the value is already being inverted in gpio_get

JIRA: RTOS-507
KSZ8081RNB is the actual Ethernet PHY on
iMX 6ULL's evaluation board

JIRA: RTOS-507
fix 7b90e8e:
- add _Atomic specifier to volatile vars used as atomics
- change operations on the vars to atomic_*

JIRA: RTOS-507
refactor packet buffer handling to support target with PAGE_SIZE < pkt_buf_sz

JIRA: RTOS-507
This eliminates the need for extra call to mphys to check
if we got contiguous memory - we can just call va2pa.

JIRA: RTOS-507
add PHY model specification to the ENET config string.
different config is needed when the target supports
different PHY model per ENET device.

JIRA: RTOS-963
Update README with appropriate information about
new changes to drivers/ephy and drivers/imx-enet.

JIRA: RTOS-963
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1170-evkb branch from 4c12eaf to 7ee4368 Compare April 28, 2025 10:49
ENET1 and ENET_1G on imxrt1170-evkb need their own, separate MDIO busses to work

JIRA: RTOS-963
Add information about iMX.RT1170's EVKB board's needed Ethernet config

JIRA: RTOS-963
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt1170-evkb branch from 7ee4368 to f8d05f5 Compare April 28, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants