drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

julianuziemblo · 2024-08-26T08:56:06Z

Description

Add Ethernet support for iMX RT106x, merging the code with existing driver for iMX 6ULL in drivers/imx-enet.c.

Motivation and Context

https://jira.phoenix-rtos.com/browse/RTOS-507

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: armv7a7-imx6ull-evk, armv7m7-imxrt106x-evk, armv7a7-imx6ull-dataro, ia32-generc-qemu.

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work:
I will merge this PR by myself when appropriate.

drivers/enet.c

drivers/enet.h

drivers/imx-enet.h

nalajcie

Partial review as current commit structure prevents efficient code review (the browser crashed with the amount of changes/comments in single commit :)).

Short summary:

fix commit message titles (see git history for examples), at least prefix them with module name (also include in commit message bodies what / why was changed), add missing JIRA ID
clearly split the changes into separate atomic commits (eg. changing type name is not bringing new functionality and should be a separate change)
fix coding style (according to our coding convention / MISRA as described in some comments)
please test the code after changes on imx6ull-evk and DTR project (from CI I see that something is broken there), check also if the performance is not degraded

_targets/Makefile.armv7a7-imx6ull

drivers/bdring.h

drivers/ephy.c

drivers/pktmem.c

drivers/imx-enet.c

drivers/ephy.c

github-actions · 2024-09-04T08:17:25Z

Unit Test Results

7 958 tests ±0 7 434 ✅ ±0 40m 50s ⏱️ +29s
470 suites ±0 524 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 37110e8. ± Comparison against base commit 6622c68.

♻️ This comment has been updated with latest results.

drivers/bdring.c

drivers/imx-enet-regs.h

drivers/imx-enet.c

nalajcie · 2024-09-13T11:23:59Z

converting to draft until it will be ready for next review

drivers/pktmem.c

JIRA: RTOS-507

refactor printfs with repeated format pattern into ephy_printf JIRA: RTOS-507

add ephy_debug_printf toggled by EPHY_DEBUG inside drivers/ephy.c and add debug prints for easier debugging JIRA: RTOS-507

JIRA: RTOS-507

first step to add separate implementation files for imx6ull and imxrt106x gpio JIRA: RTOS-507

remove active value inversion in gpio_wait because the value is already being inverted in gpio_get JIRA: RTOS-507

JIRA: RTOS-507

KSZ8081RNB is the actual Ethernet PHY on iMX 6ULL's evaluation board JIRA: RTOS-507

JIRA: RTOS-507

fix 7b90e8e: - add _Atomic specifier to volatile vars used as atomics - change operations on the vars to atomic_* JIRA: RTOS-507

refactor packet buffer handling to support target with PAGE_SIZE < pkt_buf_sz JIRA: RTOS-507

This eliminates the need for extra call to mphys to check if we got contiguous memory - we can just call va2pa. JIRA: RTOS-507

github-actions bot reviewed Aug 26, 2024

View reviewed changes

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 3185e73 to a582983 Compare August 26, 2024 12:09

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from b8059e4 to 2af33ab Compare September 3, 2024 12:58

github-actions bot reviewed Sep 3, 2024

View reviewed changes

drivers/imx-enet.h Outdated Show resolved Hide resolved

drivers/imx-enet.h Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 2af33ab to f5e973e Compare September 3, 2024 13:01

github-actions bot reviewed Sep 3, 2024

View reviewed changes

drivers/imx-enet.h Outdated Show resolved Hide resolved

phoenix-rtos deleted a comment from github-actions bot Sep 3, 2024

nalajcie requested changes Sep 3, 2024

View reviewed changes

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from f5e973e to 7dbbd7e Compare September 4, 2024 08:03

julianuziemblo requested a review from Darchiv September 6, 2024 10:03

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 7dbbd7e to 710b1d1 Compare September 6, 2024 14:57

github-actions bot reviewed Sep 6, 2024

View reviewed changes

drivers/bdring.c Outdated Show resolved Hide resolved

github-actions bot reviewed Sep 6, 2024

View reviewed changes

drivers/imx-enet-regs.h Outdated Show resolved Hide resolved

drivers/imx-enet-regs.h Outdated Show resolved Hide resolved

drivers/imx-enet-regs.h Outdated Show resolved Hide resolved

drivers/imx-enet-regs.h Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 2 times, most recently from e11d5db to 067dc1b Compare September 6, 2024 15:10

github-actions bot reviewed Sep 6, 2024

View reviewed changes

drivers/imx-enet.c Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from 8c41250 to fc32052 Compare September 10, 2024 10:19

nalajcie marked this pull request as draft September 13, 2024 11:23

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from fc32052 to f42a4cc Compare September 16, 2024 08:11

github-actions bot reviewed Sep 16, 2024

View reviewed changes

drivers/pktmem.c Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 2 times, most recently from 23199d4 to 949cbf1 Compare September 16, 2024 08:29

github-actions bot reviewed Sep 16, 2024

View reviewed changes

drivers/pktmem.c Outdated Show resolved Hide resolved

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 949cbf1 to c11c661 Compare September 16, 2024 08:31

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 4 times, most recently from f73b229 to 860b5b9 Compare April 15, 2025 08:19

ziemleszcz reviewed Apr 15, 2025

View reviewed changes

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch 3 times, most recently from 8a237ea to 3718bce Compare April 16, 2025 10:38

julianuziemblo added 13 commits April 28, 2025 12:02

drivers/imx-enet: map OTP memory 1 time

427ef80

JIRA: RTOS-507

drivers/ephy: add ephy_printf

257abdd

refactor printfs with repeated format pattern into ephy_printf JIRA: RTOS-507

drivers/ephy: add ephy_debug_printf

c8f80fb

add ephy_debug_printf toggled by EPHY_DEBUG inside drivers/ephy.c and add debug prints for easier debugging JIRA: RTOS-507

drivers/imx-enet: improve selftest debug info

7e3c55d

JIRA: RTOS-507

drivers/imx-enet: fix possible integer overflow

b595484

JIRA: RTOS-507

drivers/gpio: put all gpio functionality into imx6ull-gpio.c

70b34d7

first step to add separate implementation files for imx6ull and imxrt106x gpio JIRA: RTOS-507

drivers/imx6ull-gpio: fix gpio_wait

e446fa4

remove active value inversion in gpio_wait because the value is already being inverted in gpio_get JIRA: RTOS-507

drivers/gpio: add gpio functionality for imxrt106x

dcb2f6a

JIRA: RTOS-507

drivers/ephy: support phy KSZ8081RNB

5e82274

KSZ8081RNB is the actual Ethernet PHY on iMX 6ULL's evaluation board JIRA: RTOS-507

drivers/imx-enet: Add support for ethernet in imxrt1064-evk

07b791b

JIRA: RTOS-507

drivers/(bdring, imx-enet): fix atomic semantics

6020726

fix 7b90e8e: - add _Atomic specifier to volatile vars used as atomics - change operations on the vars to atomic_* JIRA: RTOS-507

drivers/pktmem: fix packet buffer handling

f3840bb

refactor packet buffer handling to support target with PAGE_SIZE < pkt_buf_sz JIRA: RTOS-507

drivers/physmmap: refactor dmammap to use MAP_CONTIGUOUS flag

37110e8

This eliminates the need for extra call to mphys to check if we got contiguous memory - we can just call va2pa. JIRA: RTOS-507

julianuziemblo force-pushed the julianuziemblo/enet-imxrt1064-evk branch from 3718bce to 37110e8 Compare April 28, 2025 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

julianuziemblo commented Aug 26, 2024 •

edited

Loading

nalajcie left a comment

github-actions bot commented Sep 4, 2024 •

edited

Loading

nalajcie commented Sep 13, 2024

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

Are you sure you want to change the base?

drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96

Conversation

julianuziemblo commented Aug 26, 2024 • edited Loading

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

nalajcie left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 4, 2024 • edited Loading

Unit Test Results

nalajcie commented Sep 13, 2024

julianuziemblo commented Aug 26, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading