-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various updates and improvements for v0.3.0 #17
Conversation
phip1611
commented
Jan 9, 2024
•
edited
Loading
edited
- merge of Use proper font metrics for calculating line height & update fonts #16
- prepare v0.3.0
- dependency updates
- code improvements
- example improvements
…layout characters This adds a dependency on ttf-parser, which fontdue already uses internally.
Use proper font metrics for calculating line height & update fonts
Hm. @toothbrush7777777 I can't merge it like this, unfortunately. :/ If you run The They just center it and cut it at the edges. |
@phip1611 Okay, I'll add some extra code to check if the character is too wide. The main issue seems to be that the font doesn't contain the replacement symbol ( |
I don't understand why you say that. The replacement character is there? It is just cut of on the right side? I'm not sure what's the right strategy to handle very wide characters, either. If it's not too complicated, you can try to make the symbol smaller. Otherwise, we should center it and cut it at the edges |
@toothbrush7777777 Any update? |
I don't think that the Noto Sans Mono font contains the replacement character glyph because I see an outlined box, not the glyph that you see. |
Anyway, I've fixed it in #18 by centring the glyphs. Scaling the replacement character down looked terrible at sizes smaller than 24px. |
Thank you so much for working on this! I'll merge it as soon as I'm back from my long vacation in March |
I still have this on my list! Sorry for the long delay |
Center glyphs when they are too big
This is a screenshot of the current rendering in https://github.com/rust-osdev/bootloader (on the right). The left side shows my system's default mono space rendering using Source Code Pro as font: So either something that we do or Noto Sans Mono itself causes the high line height. Nevertheless, I think that this is the best that we can get - for what it is. |
misc: various repo improvements