Use proper font metrics for calculating line height & update fonts #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layout characters This adds a dependency on ttf-parser, which fontdue already uses internally.
|
Amazing! Thanks for working on this. I'll take a look at this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
./codegen_n_update.shfor each commit to update the generated sources.This code uses the proper font metrics to compute the line height including the ascenders and descenders, so that
q,gandÄall display correctly.Note
The correct line height to font size ratio is about 0.75 rather than the current 0.84. This makes the computed font size about 10% smaller.