Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex size support #15

Merged
merged 9 commits into from
Feb 18, 2023
Merged

Flex size support #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec5e0c7
feat(flex): add flex size support
lievenjanssen Feb 15, 2023
8e04906
feat(flex): add tests for flex size support
lievenjanssen Feb 15, 2023
661226d
fix(flex): fix for generating flex size layout media queries
lievenjanssen Feb 15, 2023
79de952
fix(flex): update documentation for flex size selectors
lievenjanssen Feb 15, 2023
235b0e2
fix(flex): split up function for value list
lievenjanssen Feb 17, 2023
b07cd88
Merge branch 'master' into flex-size-support
lievenjanssen Feb 17, 2023
6ea3889
fix(flex): use modular operator to check if params of flex-size mixin…
lievenjanssen Feb 18, 2023
cc7cf07
Merge branch 'master' into flex-size-support
lievenjanssen Feb 18, 2023
8046089
fix(merge): fixed merge issue
lievenjanssen Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(flex): use modular operator to check if params of flex-size mixin… 
… is correct
  • Loading branch information
@lievenjanssen
lievenjanssen committed Feb 18, 2023
commit 6ea3889143a2cf56272c1daa6d95a0e9f6566f25
2 changes: 1 addition & 1 deletion src/lib/flex-size-attributes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
/// @param {bool} $includeSelectorsForMediaSizes
/// Will generate additional selectors for flex layout media sizes
@mixin flex-size-attributes($from: 5, $to: 100, $increment: 5, $includeSelectorsForMediaSizes: true) {
@if math.div($from, $increment) != math.round(math.div($from, $increment)) or math.div($to, $increment) != math.round(math.div($to, $increment)) {
@if $from % $increment != 0 or $to % $increment != 0 {
@error "$from (#{$from}) and $to (#{$to}) must be dividable by $increment (#{$increment}).";
}
@for $i from math.div($from, $increment) through math.div($to, $increment) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/flex-size-classes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
/// @param {bool} $includeSelectorsForMediaSizes
/// Will generate additional selectors for flex layout media sizes
@mixin flex-size-classes($from: 5, $to: 100, $increment: 5, $includeSelectorsForMediaSizes: true) {
@if math.div($from, $increment) != math.round(math.div($from, $increment)) or math.div($to, $increment) != math.round(math.div($to, $increment)) {
@if $from % $increment != 0 or $to % $increment != 0 {
@error "$from (#{$from}) and $to (#{$to}) must be dividable by $increment (#{$increment}).";
}
@for $i from math.div($from, $increment) through math.div($to, $increment) {
Expand Down