Flex size support

[lievenjanssen]

Currently I generate flex: 1 1 $value; where $value is the flex size. I was wondering if this is the correct approach or if I should just set the flex-basis like this flex-basis: $value;. What do you think?

[philmtd]

Thank you (again) for this PR!

Currently I generate flex: 1 1 $value; where $value is the flex size. I was wondering if this is the correct approach or if I should just set the flex-basis like this flex-basis: $value;. What do you think?

I think this is correct and would work according to the defaults of fxFlex in Flex Layout (checking here https://github.com/angular/flex-layout/wiki/fxFlex-API and here https://github.com/angular/flex-layout/blob/master/projects/libs/flex-layout/flex/flex/flex.ts).

So I think this implementation should be fine.

[philmtd]

I have one suggestion (twice). Could you check that? Otherwise this looks good to me.

And before I can merge it, you'd need to kindly resolve the conflicts that happend due to the other already merged PRs 🙂

[lievenjanssen]

you'd need to kindly resolve the conflicts that happened due to the other already merged PRs

Fixed. This is ready to be merged I think.

[philmtd]

Thanks! Looks good to me. I'll try to document and release everything in the next days. Is that okay with you, or do you need it asap?

[lievenjanssen]

Thanks! Looks good to me. I'll try to document and release everything in the next days. Is that okay with you, or do you need it asap?

I suggest to still do the increment change for gap selectors before we do a major version release. I would want to use it asap but I can temporarily work around that.