Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC-Lite test: Gravity and Orbits 1.2.0-rc.2 with PhET-iO #567

Closed
1 of 3 tasks
samreid opened this issue Oct 27, 2020 · 12 comments
Closed
1 of 3 tasks

RC-Lite test: Gravity and Orbits 1.2.0-rc.2 with PhET-iO #567

samreid opened this issue Oct 27, 2020 · 12 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Oct 27, 2020

@ariel-phet, @arouinfar, @kathy-phet, @KatieWoe, gravity-and-orbits/1.2.0-rc.2 is ready for RC-lite testing. This is for a client, and is one of their top priority projects. Document issues in https://github.com/phetsims/gravity-and-orbits/issues and link to this issue.

Assigning to @ariel-phet for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book
    for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Test the Game Up harness on at least one platform.
  • Check this LoL
    spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version
  • Try to include version numbers for browsers
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if
    there is a problem.

Focus and Special Instructions

This is an RC-lite test for the PhET-iO version, which will be delivered to the client once testing has passed. Prior
testing was completed in #519

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

Links will be provided once the version has been built. There are still some blocks-publication or blocks-sim-publication
issues that need to be addressed first.


PhET-iO RC Test

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.
  • For an update or maintenance release please check the backwards compatibility of the playback wrapper.
    Here's the link to the previous wrapper.
  • Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:
    /wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER
    
    Further instructions in QA Book
  • Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other random platform.
  • Conduct a memory test on the stand alone sim wrapper (rc.1).
  • Test one platform combination with ?phetioDebug on the Studio and State wrapper.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@ariel-phet ariel-phet removed their assignment Oct 27, 2020
@samreid samreid changed the title RC-Lite test: Gravity and Orbits 1.2.0-rc.1 with PhET-iO RC-Lite test: Gravity and Orbits 1.2.0-rc.2 with PhET-iO Nov 2, 2020
@samreid
Copy link
Member Author

samreid commented Nov 2, 2020

I published 1.2.0-rc.2 and added the URLs. I also moved it to "Active Tests". Reassigning to @KatieWoe so she is aware this is ready, and also assigning @ariel-phet in case any changes to priority/label/assignment are necessary.

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 2, 2020

Should the accessibility section be removed? I don't think it has any of the listed features.

@samreid
Copy link
Member Author

samreid commented Nov 2, 2020

Thanks, I removed the accessibility section.

@samreid samreid removed their assignment Nov 2, 2020
@ariel-phet ariel-phet removed their assignment Nov 3, 2020
@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 3, 2020

Not sure if this is actually a bug, so let me know if you want an issue made @samreid. Some of the changes mentioned in #572 are here. Specifically the orientation of the clear button. I also noticed that the color when the buttons aren't available is different now. Is this intended?
Screen Shot 2020-11-03 at 3 13 38 PM

@samreid
Copy link
Member Author

samreid commented Nov 3, 2020

Specifically the orientation of the clear button. I also noticed that the color when the buttons aren't available is different now.

Can you clarify what you mean by the "orientation"?

@pixelzoom or @zepumph or @jonathanolson can you please comment on the status of grayscale for disabled buttons?

@zepumph
Copy link
Member

zepumph commented Nov 3, 2020

@pixelzoom or @zepumph or @jonathanolson can you please comment on the status of grayscale for disabled buttons?

Tracked in phetsims/sun#658, I'm sorta out of the conversation, and I don't know if this blocks GAO publication. @ariel-phet, what steps need to be taken to make sure that GAO can be published? Currently it uses the "opacity" strategy from master/recent work in sun. Do we need to wait on a greyscale implementation, or talk to designers?

@zepumph zepumph assigned ariel-phet and unassigned zepumph Nov 3, 2020
@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 4, 2020

@jonathanolson is working on filtering features (including grayscale) for scenery with high priority in phetsims/scenery#707 (comment). You'll have to ask @jonathanolson or @ariel-phet about when (and how) the scenery grayscale feature is expected to be added to sun buttons.

@pixelzoom pixelzoom removed their assignment Nov 4, 2020
@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 4, 2020

@samreid

Can you clarify what you mean by the "orientation"?

It used to be centered under it's label. Now it is right justified.

@arouinfar
Copy link
Contributor

arouinfar commented Nov 4, 2020

@KatieWoe the alignment of the Clear button was an intentional change, see phetsims/gravity-and-orbits#359 (comment).

@samreid
Copy link
Member Author

samreid commented Nov 4, 2020

@jonathanolson indicated he is nearly ready to commit "grayscale" disabled support to master for phetsims/scenery#707 (comment), should I invalidate this test and create a new one once that is ready?

@samreid
Copy link
Member Author

samreid commented Nov 4, 2020

@arouinfar recommends to pause RC testing on this version until @ariel-phet or @kathy-phet comments on whether we want grayscale in the upcoming release. Also, @jonathanolson can you comment on how modular/straightforward the changes are? Will they invalidate testing and require significant re-testing?

@samreid
Copy link
Member Author

samreid commented Nov 4, 2020

After discussion with @arouinfar, @ariel-phet recommended halting this RC testing until we have the grayscale enabled components. I'll deprioritize and move it to another column in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants