Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Test: Gravity and Orbits 1.2.0-dev.16/phet-io/ #519

Closed
8 tasks done
samreid opened this issue Jul 21, 2020 · 12 comments
Closed
8 tasks done

Dev Test: Gravity and Orbits 1.2.0-dev.16/phet-io/ #519

samreid opened this issue Jul 21, 2020 · 12 comments
Assignees
Labels
QA:dev-test Dev test before an RC

Comments

@samreid
Copy link
Member

samreid commented Jul 21, 2020

@ariel-phet, @arouinfar, @kathy-phet, @KatieWoe, 1.2.0-dev.16/phet-io/ is ready for dev testing. If this passes testing,
this dev version will be delivered to a client. Ideally by 11/1 for a dev version and 12/15 for a published version, but sooner is best for a dev delivery. Please be aware this is the 2nd dev version for QA, and several of the issues discovered by QA in the first dev version were scheduled to be implemented for RC, but not for the 2nd dev version. Document issues in https://github.com/phetsims/gravity-and-orbits/issues and link to this issue.

Assigning @ariel-phet for prioritization.

General Dev Test

What to Test

  • Click every single button.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Try to include browser version numbers
  • If there is a console available, check for errors and include them in the Problem Description.
  • Run through the string tests on at least one platform, especially if it is about to go to rc.

Focus and Special Instructions

Only the PhET-iO version will be delivered to the client, but any bugs discovered in the PhET brand version will likely
appear in the PhET-iO version as well.

General Dev Test Platforms

  • Latest macOS, Chrome and Safari
  • Latest iOS, Safari
  • Windows 10, all browsers (IE dropped)
  • Latest Chrome OS, Chrome

These issues should have either use the labels "status:ready-for-qa" or "status:ready-for-review." If it is ready for
QA then close the issue if fixed. If ready for review then leave open and assign back to the developer.

Link(s)


PhET-iO Dev Test

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.

General Dev Test Platforms

  • Latest macOS, all browsers
  • Latest iOS, Safari
  • Windows 10, all browsers (IE dropped)
  • Latest Chrome OS, Chrome

Focus and Special Instructions

For this version, studio and customizability are more important than other features like data stream.

Link(s)


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@samreid samreid added the QA:dev-test Dev test before an RC label Jul 21, 2020
@samreid
Copy link
Member Author

samreid commented Jul 21, 2020

Adding a reference to the issue where we prepared the dev version: phetsims/gravity-and-orbits#345

@ariel-phet
Copy link
Contributor

Putting at medium priority at the moment, given the current QA backlog

@zepumph
Copy link
Member

zepumph commented Jul 30, 2020

Discussed today during phet-io meeting. This dev version most likely has all the same phet-io bugs as reported in #514. These are currently fixed on master, but likely we should take a GAO dev version from master now before testing this.

@zepumph
Copy link
Member

zepumph commented Jul 30, 2020

@pixelzoom mentioned that perhaps the best process is to have @KatieWoe ping @samreid when she is ready to test this. Then we can get a fresh dev version at that time.

@samreid
Copy link
Member Author

samreid commented Aug 3, 2020

I agree, the dev version 1.2.0-dev.12 is stale, please reach out to me when ready for testing and I'll publish a new version.

@samreid
Copy link
Member Author

samreid commented Aug 19, 2020

@ariel-phet or @KatieWoe can you estimate when QA may be ready for the next dev test for Gravity and Orbits? It may help us ensure master is stable around that time.

@samreid samreid assigned ariel-phet and unassigned samreid Aug 19, 2020
@ariel-phet
Copy link
Contributor

@samreid I think around Monday Aug 31st would be my guess currently, depending on how Ph Scale testing and such goes next week

@ariel-phet ariel-phet assigned samreid and unassigned ariel-phet and KatieWoe Aug 19, 2020
@samreid samreid removed their assignment Aug 20, 2020
@samreid
Copy link
Member Author

samreid commented Sep 15, 2020

@samreid samreid changed the title Dev Test: Gravity and Orbits 1.2.0-dev.12/phet-io/ Dev Test: Gravity and Orbits 1.2.0-dev.16/phet-io/ Sep 15, 2020
@KatieWoe
Copy link
Contributor

I've sometimes seen times where the path doesn't fade, but I can't reproduce it reliably, I just see it some times. @arouinfar if you want to go over it let me know, but I'm not always convinced I'm seeing anything and I don't know what causes it, so let me know if you want an issue for it.
To be clear, the path goes away, but it does it suddenly, rather than tapering off.

@KatieWoe
Copy link
Contributor

QA is done

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Oct 15, 2020
@arouinfar
Copy link
Contributor

To be clear, the path goes away, but it does it suddenly, rather than tapering off.

This sounds like the path occasionally has full opacity, which seems relatively minor to me. Given that it isn't reliably reproduced, I don't think it warrants an issue.

@samreid
Copy link
Member Author

samreid commented Oct 16, 2020

All issues mentioned above are closed, ready for review or on my project board. Thanks for the great test @KatieWoe, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:dev-test Dev test before an RC
Projects
None yet
Development

No branches or pull requests

5 participants