Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons and screenshots may need to be retaken #366

Closed
KatieWoe opened this issue Nov 3, 2020 · 9 comments
Closed

Icons and screenshots may need to be retaken #366

KatieWoe opened this issue Nov 3, 2020 · 9 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 3, 2020

Test device
MacBook Air
Operating System
10.15.7
Browser
Chrome
Problem description
For phetsims/qa#567
I noticed that the velocity arrow is now a different color (now green instead of red). However, the icon for the second screen on the home page and in the nav bar still shows the arrow as red. I also noticed that the changes to the color of inactive buttons means that screenshots may need to be changed.

Visuals
Screen Shot 2020-11-03 at 3 41 38 PM
Screen Shot 2020-11-03 at 3 41 48 PM

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Gravity and Orbits‬
URL: https://phet-dev.colorado.edu/html/gravity-and-orbits/1.2.0-rc.2/phet/gravity-and-orbits_all_phet.html
Version: 1.2.0-rc.2 2020-11-02 23:34:16 UTC
Features missing: applicationcache, applicationcache, touch
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36
Language: en-US
Window: 1306x685
Pixel Ratio: 1/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 15 uniform: 1024
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80)
Max viewport: 16384x16384
OES_texture_float: true
Dependencies JSON: {}

@samreid
Copy link
Member

samreid commented Nov 4, 2020

The screen icons are checked in to mipmaps/ rather than generated in code. @arouinfar can you please take the lead on this?

@samreid samreid removed their assignment Nov 4, 2020
@arouinfar
Copy link
Contributor

arouinfar commented Nov 4, 2020

@samreid I updated the screen icons and cleaned them up a bit. The .ai assets currently checked in for the icons (cartoon_icon.ai and to_scale_icon.ai) have a weird encoding issue and look like text files when trying to open them up in Illustrator. Luckily, I had a local copy from when they were originally created that didn't have this issue. I am going to delete the old .ai files and upload the new screen icons as a single file. I'm not sure why the .png versions of the icons aren't currently checked in. I'm not 100% where those should go, so attaching them here instead:
model-screen-icon.png
to-scale-screen-icon.png

@arouinfar
Copy link
Contributor

Okay, scratch that, screen-icons.ai comes in at a whopping 43MB which is too big to commit through the GitHub web interface and doesn't zip small enough to attach to the issue. The large file size is due to the image of the Earth used in the icons. I don't want to compress it down because it could compromise the quality in the exported images. @samreid I've temporarily uploaded the screen icons to the sim design folder on Drive. I'm assuming there shouldn't be a file size issue if you commit it from your local machine.
https://drive.google.com/file/d/1nt7D0RGT3txOcgvj1-_fDFU87mcwUHjp/view

@arouinfar
Copy link
Contributor

arouinfar commented Nov 4, 2020

I was able to reduce the source image of the Earth down to 2.6 MB, resulting in a final .ai size of 10.4 MB. @samreid here are the updated assets.
screen-icons-reduced-size.zip

@arouinfar
Copy link
Contributor

I updated the screenshots in master and the 1.2 branch in the above commits.

@samreid
Copy link
Member

samreid commented Nov 10, 2020

Thanks! I will run grunt modulify to produce the JS assets. Also, I think the next version will take SHAs from master and go forward as 1.3

@samreid samreid added this to the 1.3 "rc-lite" milestone Nov 11, 2020
samreid added a commit that referenced this issue Nov 12, 2020
@samreid
Copy link
Member

samreid commented Nov 12, 2020

I pushed the icons in the commit, @arouinfar can you please check that they are correct?

@arouinfar
Copy link
Contributor

Looks great @samreid!

@samreid
Copy link
Member

samreid commented Nov 12, 2020

Thanks, closing.

@samreid samreid closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants