Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review each file together as a pre-code review step #31

Closed
samreid opened this issue Jan 5, 2024 · 3 comments
Closed

Review each file together as a pre-code review step #31

samreid opened this issue Jan 5, 2024 · 3 comments
Assignees
@matthew-blackman

Comments

@samreid
Copy link
Member

samreid commented Jan 5, 2024

No description provided.

@samreid
Copy link
Member Author

samreid commented Jan 5, 2024

@matthew-blackman said:

I have a few places to update beforehand: LauncherNode, HeatMapToolNode

@samreid samreid added the dev:help-wanted Extra attention is needed label Jan 5, 2024
@samreid samreid removed their assignment Jan 5, 2024
@matthew-blackman
Copy link
Contributor

@samreid mentioned that the overall codebase has improved since this issue was created, and we no longer need to review each file line-by-line. @matthew-blackman would still like to review the following files, first asynchronously and then synchronously with @samreid:

  • Field.ts
  • SamplingModel.ts
  • All ScreenView files
  • LauncherNode.ts and CustomLauncherNode.ts
  • HeatmapToolNode.ts and both subclasses
  • DataMeasuresOverlay.ts

@matthew-blackman matthew-blackman removed the dev:help-wanted Extra attention is needed label Feb 19, 2024
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Add documentation, see #31
b2762c8
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Add documentation, see #31
81daf6a
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Add documentation, see #31
936c78e
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Formatting, see #31
4e7d6ea
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Update documentation, see #31
a1aa1bb
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Update documentation, see #31
830d144
samreid added a commit that referenced this issue Feb 21, 2024
@samreid
Update documentation, see #31
c617c3a
samreid added a commit that referenced this issue Feb 26, 2024
@samreid
Add documentation, see #31
fa79327
samreid added a commit that referenced this issue Feb 26, 2024
@samreid
Add documentation, see #31
65028c4
samreid added a commit that referenced this issue Feb 26, 2024
@samreid
Remove unused parameters, see #31
c10f4f0
samreid added a commit that referenced this issue Feb 26, 2024
@samreid
Remove unused parameters, see #31
01ecb41
samreid added a commit that referenced this issue Feb 26, 2024
@samreid
Remove unused parameters, see #31
61c2b08
matthew-blackman added a commit that referenced this issue Feb 27, 2024
@matthew-blackman
Add documentation and perform minor refactor of heat map tools - see #31
639adaa
@samreid
Copy link
Member Author

samreid commented Feb 27, 2024

We finish setting up for code review in #183, closing.

@samreid samreid closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-blackman matthew-blackman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @matthew-blackman