Remove unused parameters, see #31

js/common-vsm/view/ProjectileSelectorNode.ts

@@ -124,8 +124,8 @@ export default class ProjectileSelectorNode extends SelectorNode {
       visibleProperty: new DerivedProperty( [ selectedProjectileProperty ], projectile => projectile !== null )
     } );
 
-    Multilink.multilink( [ selectedProjectileNumberProperty, numberOfLandedProjectilesProperty, selectedProjectileProperty ],
-      ( selectedProjectileNumber, numberOfLandedProjectiles, selectedProjectile ) => {
+    Multilink.multilink( [ selectedProjectileProperty, selectedProjectileNumberProperty, numberOfLandedProjectilesProperty ],
+      selectedProjectile => {
 
         if ( selectedProjectile ) {
 

js/common-vsm/view/VSMFieldSignNode.ts

@@ -15,7 +15,6 @@ import { Text, VBox } from '../../../../scenery/js/imports.js';
 import PDLConstants from '../../common/PDLConstants.js';
 import TReadOnlyProperty from '../../../../axon/js/TReadOnlyProperty.js';
 import Field from '../../common/model/Field.js';
-import ModelViewTransform2 from '../../../../phetcommon/js/view/ModelViewTransform2.js';
 import { EmptySelfOptions } from '../../../../phet-core/js/optionize.js';
 import PDLColors from '../../common/PDLColors.js';
 import ProjectileSelectorNode from './ProjectileSelectorNode.js';
@@ -27,8 +26,6 @@ type VSMFieldSignNodeOptions = SelfOptions & FieldSignNodeOptions;
 export default class VSMFieldSignNode extends FieldSignNode {
   public constructor( fields: Field[],
                       fieldProperty: TReadOnlyProperty<Field>,
-                      numberOfLandedProjectilesProperty: TReadOnlyProperty<number>,
-                      modelViewTransform: ModelViewTransform2,
                       projectileSelectorNode: ProjectileSelectorNode,
                       providedOptions?: VSMFieldSignNodeOptions ) {
 
@@ -51,7 +48,7 @@ export default class VSMFieldSignNode extends FieldSignNode {
       maxWidth: 100
     } );
 
-    super( fields, fieldProperty, fieldSignHeadingContainer, projectileSelectorNode, 34, options );
+    super( fieldProperty, fieldSignHeadingContainer, projectileSelectorNode, 34, options );
   }
 }
 

js/common-vsm/view/VSMScreenView.ts

@@ -232,8 +232,6 @@ export default abstract class VSMScreenView<T extends VSMField> extends PDLScree
     this.fieldSignNode = new VSMFieldSignNode(
       model.fields,
       model.fieldProperty,
-      model.numberOfLandedProjectilesProperty,
-      this.modelViewTransform,
       this.projectileSelectorNode
     );
 

js/common/view/FieldNode.ts

@@ -35,7 +35,7 @@ export default class FieldNode extends Node {
   // The field
   private readonly fieldBorder: Node;
 
-  public constructor( fields: Field[], fieldProperty: TReadOnlyProperty<Field>, binWidthProperty: TReadOnlyProperty<number>, providedOptions: FieldNodeOptions ) {
+  public constructor( fieldProperty: TReadOnlyProperty<Field>, binWidthProperty: TReadOnlyProperty<number>, providedOptions: FieldNodeOptions ) {
 
     const fieldBounds = new Bounds2(
       -0.5 * PDLConstants.FIELD_WIDTH,

js/common/view/FieldSignNode.ts

@@ -21,12 +21,12 @@ type SelfOptions = EmptySelfOptions;
 export type FieldSignNodeOptions = SelfOptions & VBoxOptions;
 
 export default class FieldSignNode extends VBox {
-  public constructor( fields: Field[],
-                      fieldProperty: TReadOnlyProperty<Field>,
-                      private readonly headingText: Node,
-                      selectorNode: SelectorNode,
-                      signPostHeight: number,
-                      providedOptions: FieldSignNodeOptions ) {
+  public constructor(
+    fieldProperty: TReadOnlyProperty<Field>,
+    private readonly headingText: Node,
+    selectorNode: SelectorNode,
+    signPostHeight: number,
+    providedOptions: FieldSignNodeOptions ) {
 
     const options = optionize<FieldSignNodeOptions, SelfOptions, VBoxOptions>()( {
       stretch: true

js/common/view/PDLScreenView.ts

@@ -142,11 +142,11 @@ export default abstract class PDLScreenView<T extends Field> extends ScreenView
       eraseResetContainerProxy.bottom = this.layoutBounds.maxY - PDLConstants.SCREEN_VIEW_Y_MARGIN;
     } );
 
-    const fieldBack = new FieldNode( model.fields, model.fieldProperty, model.histogram.binWidthProperty, {
+    const fieldBack = new FieldNode( model.fieldProperty, model.histogram.binWidthProperty, {
       x: fieldX,
       y: fieldY
     } );
-    const fieldFront = new FieldNode( model.fields, model.fieldProperty, model.histogram.binWidthProperty, {
+    const fieldFront = new FieldNode( model.fieldProperty, model.histogram.binWidthProperty, {
       isBottomHalf: true,
       x: fieldX,
       y: fieldY

js/common/view/SimulationPreferencesContentNode.ts

@@ -6,7 +6,7 @@
  * @author Sam Reid (PhET Interactive Simulations)
  */
 
-import { Node, Rectangle, RichText } from '../../../../scenery/js/imports.js';
+import { Rectangle, RichText } from '../../../../scenery/js/imports.js';
 import PreferencesControl from '../../../../joist/js/preferences/PreferencesControl.js';
 import PreferencesDialogConstants from '../../../../joist/js/preferences/PreferencesDialogConstants.js';
 import Tandem from '../../../../tandem/js/Tandem.js';
@@ -22,7 +22,7 @@ import { Checkbox } from '../../../../sun/js/imports.js';
 
 export default class SimulationPreferencesContentNode extends PreferencesPanelContentNode {
 
-  public constructor( parentNode: Node, tandem: Tandem ) {
+  public constructor( tandem: Tandem ) {
 
     const autoGenerateDataControlTandem = tandem.createTandem( 'autoGenerateDataControl' );
     const projectileTypeAffectsSpeedControlTandem = tandem.createTandem( 'projectileTypeAffectsSpeedControl' );

js/projectile-data-lab-main.ts

@@ -27,7 +27,7 @@ simLauncher.launch( () => {
   const preferencesModel = new PreferencesModel( {
     simulationOptions: {
       customPreferences: [ {
-        createContent: tandem => new SimulationPreferencesContentNode( phet.joist.sim.topLayer, tandem.createTandem( 'simPreferences' ) )
+        createContent: tandem => new SimulationPreferencesContentNode( tandem.createTandem( 'simPreferences' ) )
       } ]
     }
   } );

js/sampling/model/SamplingField.ts

@@ -159,7 +159,7 @@ export default class SamplingField extends Field {
       phetioDocumentation: 'Mark the time when a phase began, so we can track how long we have been in the phase. For PhET-iO internal use only for managing state save and load.'
     } );
 
-    const phaseChanged = ( phase: SamplingPhase ) => {
+    const phaseChanged = () => {
       this.phaseStartTimeProperty.value = this.timeProperty.value;
       this.updateComputedProperties();
     };

js/sampling/model/SamplingModel.ts

@@ -166,7 +166,7 @@ export default class SamplingModel extends PDLModel<SamplingField> {
 
     // When the field is changed, if the phase is showingAirborneProjectiles or showingCompleteSampleWithoutMean, change the mode from
     // continuous to single
-    this.fieldProperty.lazyLink( field => {
+    this.fieldProperty.lazyLink( () => {
 
       // redo all fields with the same mystery launcher, unless they already have data.
       this.fields.forEach( field => {

js/sampling/view/SamplingAccordionBox.ts

@@ -58,8 +58,7 @@ export default class SamplingAccordionBox extends HistogramAccordionBox {
       histogram,
       histogramSoundEnabledProperty,
       ProjectileDataLabStrings.meanDistanceStringProperty,
-      comboBoxParent,
-      clearCurrentField, {
+      comboBoxParent, {
         tandem: providedOptions.tandem.createTandem( 'histogramNode' )
       } );
 

js/sampling/view/SamplingFieldSignNode.ts

@@ -7,7 +7,6 @@ import ProjectileDataLabStrings from '../../ProjectileDataLabStrings.js';
 import { Text, VBox } from '../../../../scenery/js/imports.js';
 import PDLConstants from '../../common/PDLConstants.js';
 import TReadOnlyProperty from '../../../../axon/js/TReadOnlyProperty.js';
-import ModelViewTransform2 from '../../../../phetcommon/js/view/ModelViewTransform2.js';
 import { EmptySelfOptions } from '../../../../phet-core/js/optionize.js';
 import PDLColors from '../../common/PDLColors.js';
 import Launcher from '../../common/model/Launcher.js';
@@ -29,7 +28,6 @@ export default class SamplingFieldSignNode extends FieldSignNode {
                       fieldProperty: TReadOnlyProperty<Field>,
                       launcherProperty: TReadOnlyProperty<Launcher>,
                       sampleSizeProperty: TReadOnlyProperty<number>,
-                      modelViewTransform: ModelViewTransform2,
                       sampleSelectorNode: SampleSelectorNode,
                       providedOptions?: SamplingFieldSignNodeOptions ) {
 
@@ -61,7 +59,7 @@ export default class SamplingFieldSignNode extends FieldSignNode {
       maxWidth: 120
     } );
 
-    super( fields, fieldProperty, fieldSignHeadingContainer, sampleSelectorNode, 25, options );
+    super( fieldProperty, fieldSignHeadingContainer, sampleSelectorNode, 25, options );
   }
 }
 

js/sampling/view/SamplingHistogramNode.ts

@@ -37,7 +37,6 @@ export default class SamplingHistogramNode extends HistogramNode {
                       histogramSoundEnabledProperty: TReadOnlyProperty<boolean>,
                       horizontalAxisLabelText: TReadOnlyProperty<string>,
                       comboBoxParent: Node,
-                      clearCurrentField: () => void,
                       options: HistogramNodeOptions ) {
 
     super(

js/sampling/view/SamplingScreenView.ts

@@ -132,7 +132,6 @@ export default class SamplingScreenView extends PDLScreenView<SamplingField> {
       model.fieldProperty,
       model.launcherProperty,
       model.sampleSizeProperty,
-      this.modelViewTransform,
       sampleSelectorNode
     );
 
@@ -206,8 +205,8 @@ export default class SamplingScreenView extends PDLScreenView<SamplingField> {
       } );
 
     // Position the time control node so that it is right-aligned underneath the accordion box
-    ManualConstraint.create( this, [ this.timeControlNode, this.accordionBox.bottomThumbnailNode, this.accordionBox ],
-      ( timeControlNodeProxy, bottomThumbnailNodeProxy, accordionBoxProxy ) => {
+    ManualConstraint.create( this, [ this.timeControlNode, this.accordionBox, this.accordionBox.bottomThumbnailNode ],
+      ( timeControlNodeProxy, accordionBoxProxy ) => {
         timeControlNodeProxy.right = accordionBoxProxy.right - 3;
         timeControlNodeProxy.top = accordionBoxProxy.bottom + PDLConstants.INTER_PANEL_SPACING + PDLConstants.TIME_CONTROL_MARGIN_TOP;
       } );