publish PhET-iO dev versions for the client

[pixelzoom]

@kathy-phet would like to deliver PhET-iO dev versions of both ph-scale and ph-scale-basics to the client for review.

From status meeting, the process is:

1. @kathy-phet sign off on open issues labeled "status:blocks-publication"
2. @pixelzoom: publish dev versions, add links to this issue
3. @arouinfar: review and sign off
4. @kathy-phet: delivery to the client

[pixelzoom]

1. @kathy-phet sign off on open issues labeled "status:blocks-publication"

GitHub issues labeled "blocks-publication" as of Fri Apr 17 17:10:33 MDT 2020. A checked box indicates that the issue was identified as non-blocking for these dev versions.

• Improvements to phet-io general tandem structure joist#627
• phetsims/phet-io-wrappers#342
• Use Emitter (or a variant) instead of Events scenery#490
• Remove NodeIO PhET-iO sub Properties scenery#1046
• phetsims/studio#119
• phetsims/studio#40
• phetsims/studio#37
• phetsims/studio#35
• phetsims/studio#30
• phetsims/studio#28
• phetsims/studio#22
• phetsims/studio#18
• phetsims/studio#16
• phetsims/studio#14
• ComboBox: selected item may not appear in the list sun#591

Slack discussion

Summary of Slack message to @arouinfar @kathy-phet @ariel-phet @samreid @zepumph @chrisklus about the above issues

Amy Rouinfar 4:52 PM
The studio issues only block RC publication.

Amy Rouinfar 4:59 PM
I don’t see why sun 591 is blocking.
Chris Malley 4:59 PMhttps://github.com/phetsims/sun/issues/591 is blocking because it's parent issue was blocking, phetsims/sun#588 (edited)

Amy Rouinfar 5:01 PM
phetsims/phet-io-wrappers#342 shouldn’t block ph-scale. I commented in the ph-scale specific issue about this, see #161 (comment)

Michael Kauzmann 5:05 PM
Large systemic change to scenery that is unreviewed and after your dev test. . . Master is working, and the phet-io team + JO worked on some more of it today. I'm a bit worried about those being published. 490 has been in master for over a week and has not caused trouble though. So likely it is fine for a dev version review delivery.

Kathy Perkins 5:12 PM
Looks like #490 has led API changes that I would like to understand before delivering another dev version.

phetsims/scenery#490 has not been cleared as non-blocking. Assigned to @kathy-phet for followup.

[kathy-phet]

OK - We will pick this up next week.

[chrisklus]

From phetsims/scenery#1046 (comment):

visibleProperty is broken in Studio on master. Marking blocks-publication and adding to the list in #164.

I'll start looking into the problem.

[samreid]

From the slack thread:

Sam Reid Apr 17th at 5:15 PM
I don’t think #490 led to API changes in itself. And our work in phetsims/scenery#1046 was complex and systemic but did not change the API (if i recall correctly.)
1 reply

Chris Klusendorf 5 days ago
indeed!

[samreid]

In today's dev meeting, we agreed that code reviews are not blocking for phetsims/scenery#1046 or phetsims/scenery#490, and as long as they pass our internal QA dev test, it will be OK to share with the client. But we will need to fix the visibleProperty issue identified in phetsims/scenery#1046 (comment) first.

[chrisklus]

The visibleProperty problem from phetsims/scenery#1046 is fixed. Checking off the blocks-publication list.

[ariel-phet]

For phetsims/scenery#490 I discussed with @pixelzoom and @samreid - this is an internal implementation detail and optimization, and not necessary for @kathy-phet to review. It does not affect the iO API and I can sign off for this issue.

@pixelzoom will continue with dev versions (although I cannot of course make the call to deliver to the client)

[pixelzoom]

Thanks @ariel-phet. Self assigning, and I'll proceed with creating and testing dev versions.

[pixelzoom]

Here are links to the dev versions.

pH Scale: Basics
https://phet-dev.colorado.edu/html/ph-scale-basics/1.4.0-dev.3/phet-io/
https://phet-dev.colorado.edu/html/ph-scale-basics/1.4.0-dev.3/phet/ph-scale-basics_en_phet.html

pH Scale
https://phet-dev.colorado.edu/html/ph-scale/1.4.0-dev.20/phet-io/
https://phet-dev.colorado.edu/html/ph-scale/1.4.0-dev.20/phet/ph-scale_en_phet.html

From the Wrapper Index, I tested the links for Standalone, Studio, and State Wrapper (all with and without ?fuzz). In Studio, I also tested the "Launch" feature. I did not see any problems.

Over to @arouinfar for review and sign-off.

[arouinfar]

Thanks @pixelzoom. Everything looks good to me.

@kathy-phet the sim is ready for delivery to the client. I've shared the links to the guide docs on Slack.

[kathy-phet]

Thanks! Dev version sent to client, closing!

[pixelzoom]

Great! Looking forward to getting feedback and moving on to RC.