-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac Firefox: Playback wrapper doesn't work when console is closed #161
Comments
This issue is blocked until phetsims/phet-io-wrappers#342 is resolved. |
Over in https://github.com/phetsims/phet-io-wrappers/issues/342#issuecomment-612194563, @zepumph said:
Therefore I'm going to label this issue as "blocks-sim-publication". |
@kathy-phet says that this issue does not block the dev delivery to the client, but should be addressed before rc. |
Client feedback has been received and a production version is due "late August" (see #166). So undeferring this issue. Still blocked by phetsims/phet-io-wrappers#342. |
In https://github.com/phetsims/phet-io-wrappers/issues/342#issuecomment-655813141, @zepumph said:
I replied that whether the new issue is blocking is not my call - it's up to designers. Assigning this issue to @arouinfar to decide whether https://github.com/phetsims/phet-io-wrappers/issues/352 is blocking for this pH Scale. |
@KatieWoe has already verified that https://github.com/phetsims/phet-io-wrappers/issues/342 has been fixed. After great frustration in figuring out how to use the recording and playback wrappers, I was unable to reproduce https://github.com/phetsims/phet-io-wrappers/issues/352 in Mac/Firefox so I wouldn't consider it blocking. I think we can go ahead and close this issue. |
ph-scale suffers from https://github.com/phetsims/phet-io-wrappers/issues/342 (Mac Firefox: Playback wrapper doesn't work without console open).
@arouinfar is this a pre-requisite for publishing ph-scale 1.4.0 ? If so, please provide the iO team with requested priority in that issue.
The text was updated successfully, but these errors were encountered: