Skip to content

Commit

Permalink
Revert "Revert "Create annual as a versioned clone of perennial, see p…
Browse files Browse the repository at this point in the history
…hetsims/chipper#1018""

This reverts commit 25cacee241319daae825fa2b863797bb4b7db43b.
  • Loading branch information
samreid authored and zepumph committed Oct 22, 2024
1 parent e84c407 commit 64ca06b
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 1 deletion.
19 changes: 19 additions & 0 deletions eslint/chipper_eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Copyright 2018, University of Colorado Boulder
// @author Michael Kauzmann


/**
* The node-specific eslint config applied only to "server-side" files that aren't run in sims.
*/
module.exports = {
extends: './node_eslintrc.js',
env: {

// specify appropriate environment vars for node code
browser: false,
node: true
},
rules: {
'bad-chipper-text': 'error'
}
};
30 changes: 30 additions & 0 deletions eslint/rules/bad-chipper-text.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Copyright 2019, University of Colorado Boulder
/* eslint-disable bad-sim-text */

/**
* Lint detector for invalid text in chipper
* Lint is disabled for this file so the bad texts aren't themselves flagged.
*
* @author Sam Reid (PhET Interactive Simulations)
* @author Michael Kauzmann (PhET Interactive Simulations)
*/

module.exports = function( context ) {

const getBadTextTester = require( './getBadTextTester' );

// see getBadTextTester for schema.
const forbiddenTextObjects = [

// chipper should use annual instead of perennial, so that it can check out specific versions
'../perennial/js/'
];

return {
Program: getBadTextTester( forbiddenTextObjects, context )
};
};

module.exports.schema = [
// JSON Schema for rule options goes here
];
3 changes: 2 additions & 1 deletion eslint/rules/todo-should-have-issue.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ catch( e ) {
let directoriesToRequireIssues = [];
if ( buildJSON && buildJSON.common && buildJSON.common.phetLibs ) {

directoriesToRequireIssues = buildJSON.common.phetLibs.filter( x => x !== 'scenery' && x !== 'dot' && x !== 'kite' );
// Don't require issues in these repos:
directoriesToRequireIssues = buildJSON.common.phetLibs.filter( x => x !== 'scenery' && x !== 'dot' && x !== 'kite' && x !== 'annual' );

if ( buildJSON && buildJSON[ 'phet-io' ] && buildJSON[ 'phet-io' ].phetLibs ) {
directoriesToRequireIssues = directoriesToRequireIssues.concat( buildJSON[ 'phet-io' ].phetLibs );
Expand Down

0 comments on commit 64ca06b

Please sign in to comment.