Chipper and perennial have copies of execute.js, and one is stale

[samreid]

Assigning the developers with the most commits on those files. How do you recommend to proceed?

[jonathanolson]

They are quite different, presumably best to leave separate?

[zepumph]

They are quite different, presumably best to leave separate?

Yes but not for any good reason. It just looks like they have grown as they have needed to, but I see no reason, besides the annoyance of this problem, that stderr as an arg to ExecuteError (in perennial but not chipper), or shell option (in chipper but not perennial) shouldn't be supported generally.

The only issue I see is winston because it is used by the build server. Perhaps we can still work around that.

[jonathanolson]

The only issue I see is winston because it is used by the build server. Perhaps we can still work around that.

And chipper prefers grunt logging? Could we wrap chipper to use winston? I definitely have a preference for the perennial version in general (with the shell option added?)

[samreid]

Should we adopt the same policy as SimVersion, which has the primary copy in perennial and one copied to chipper on a regular basis?

[jonathanolson]

Should we adopt the same policy as SimVersion, which has the primary copy in perennial and one copied to chipper on a regular basis?

Maybe there should be a directory of code which works like this?

[zepumph]

Good idea!

[samreid]

I'm not sure of the best directory location or name. How about:

perennial/js/chipper/ ?

[samreid]

I recommend to have the destination directory in chipper be named using a similar pattern. Perhaps the copy will be from perennial/js/chipper/ to chipper/js/perennial/

[samreid]

On second thought, those names seem too awkward. It sounds like perennial/js/chipper code is intended primarily for chipper, which is not the case. Perhaps we should create a better name to unify these. A unique name (not used widely in our project) to mean "used in both perennial and chipper". Perhaps "biannual" or "dual". Or maybe perennial would have dual-source and chipper would have dual-target. Or we could use parent/child or original/copy. Maybe we'll start with dual and see how that goes.

[samreid]

I moved SimVersion to dual/ and ran grunt update on all active repos. I tested the following things:

Launching an unbuilt simulation
Building a simulation, launching it

I could not test a chains rc release with working copy changes, so I'll commit next. This is going to span many repos since a preload path changed.

I messaged Slack:

For #1018 I’m moving SimVersion to a subdirectory. This will require running grunt update on every repo. Brace yourselves for many commits.

[samreid]

Sounds like @jonathanolson is on the case for this maintenance fix, so I've updated the assignees.

[jonathanolson]

Is... there something to discuss in dev meeting? Or did that just show up because I reopened the issue? I have nothing that needs discussing at dev meeting.

[jonathanolson]

Handled in the maintenance release, closing.