Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String file housekeeping #151

Closed
5 tasks done
phet-steele opened this issue Nov 13, 2017 · 2 comments
Closed
5 tasks done

String file housekeeping #151

phet-steele opened this issue Nov 13, 2017 · 2 comments
Assignees

Comments

@phet-steele
Copy link
Contributor

phet-steele commented Nov 13, 2017

Looking at masses-and-springs-strings_en.json, there are some small changes to be made to follow convention and to clean it up:

  • I would recommend making this file alphabetical.
  • Screen title string keys should follow the convention: screen.{{screenName}}, eg.
 "screen.intro": {
    "value": "Intro"
  }

not

 "intro": {
    "value": "Intro"
  }
 "body.zeroG": {
    "value": "0 g"
  }
  • "Slow Motion" should be changed to "Slow". Change the string key as well.

For phetsims/qa/issues/67.

@phet-steele
Copy link
Contributor Author

Looks good to me, thanks @Denz1994. We'll close this and wait for a code review to see if there are any remaining issues. Note that also now all files that still say "Vector", like VectorScreenView.js, should be changed to "Vectors". Ought to be fun.

@Denz1994
Copy link
Contributor

Denz1994 commented Dec 8, 2017

The variable and file names that reference the Vectors tab have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants