Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String file cleanup #66

Closed
Denz1994 opened this issue Aug 31, 2018 · 2 comments
Closed

String file cleanup #66

Denz1994 opened this issue Aug 31, 2018 · 2 comments
Assignees

Comments

@Denz1994
Copy link
Contributor

Denz1994 commented Aug 31, 2018

It was advised by @phet-steele to alphebetize this list of strings in the respective .json files (phetsims/masses-and-springs#151). I am relaying this suggestion along to @mbarlow12 for inverse-square-law-common-strings_en.json and coulombs-law-strings_en.json.

Also, consider changing to screen.macroScale and screen.atomicScale. Currently, the file reads like this:

 "screen.macro": {
    "value": "Macro Scale"
  },
  "screen.atomic": {
    "value": "Atomic Scale"
  },
@mbarlow12
Copy link
Contributor

@Denz1994 thanks for passing along. I've made the changes; do you prefer closing issues you've opened?

@mbarlow12 mbarlow12 assigned Denz1994 and unassigned mbarlow12 Sep 25, 2018
@Denz1994
Copy link
Contributor Author

You can close them @mbarlow12. They seem pretty straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants