Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tea kettle preloaded energy chunks have a gap #178

Closed
chrisklus opened this issue Jan 16, 2019 · 9 comments
Closed

Tea kettle preloaded energy chunks have a gap #178

chrisklus opened this issue Jan 16, 2019 · 9 comments

Comments

@chrisklus
Copy link
Contributor

Found when fixing #176.

After the tea kettle is steaming and then energy chunks are turned on, there is a gap between the initial stream of chunks and the chunks that follow out of the burner.

kapture 2019-01-16 at 16 15 20

@arouinfar and I think that the preloaded energy chunks should originate from the burner instead of the center of the tea kettle (which would close the gap), but this is lower priority than other issues.

@jbphet
Copy link
Contributor

jbphet commented Jan 24, 2019

This behavior is also present in the Java sim.

@chrisklus
Copy link
Contributor Author

This is fixed, closing.

@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 5, 2019

This can happen to a minor degree if you switch tabs and come back. For phetsims/qa#293
slighthiccup

@KatieWoe KatieWoe reopened this Mar 5, 2019
@KatieWoe
Copy link
Contributor

KatieWoe commented Mar 5, 2019

Second unintended consequence: I noticed that when turning on energy chunks you can get a situation where chunks appear to be coming from an empty bucket.
https://drive.google.com/file/d/1a2IiTkoh0xKLUbtXJzNztsXVtA2AcQSj/view?usp=sharing

chrisklus added a commit that referenced this issue Mar 15, 2019
@chrisklus
Copy link
Contributor Author

#178 (comment) has been fixed by capping the max dt for a time step.

@chrisklus
Copy link
Contributor Author

#178 (comment) has also been fixed. Now, if the burner is on when chunks are being preloaded, the chunks originate from the burner, but it the burner is off when they're being preloaded, then they originate from the tea kettle.

@chrisklus
Copy link
Contributor Author

@KatieWoe could you please verify my changes above on master and close if all looks good?

@KatieWoe
Copy link
Contributor

I would say this looks pretty good on master.

@KatieWoe
Copy link
Contributor

Looks good in 1.1.0-rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants