Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam node from tea kettle looks fairly lame #123

Closed
jbphet opened this issue Nov 30, 2018 · 6 comments
Closed

Steam node from tea kettle looks fairly lame #123

jbphet opened this issue Nov 30, 2018 · 6 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Nov 30, 2018

The steam node's appearance could be improved with some better drawing code. Here's what it looks like now:

image

@chrisklus
Copy link
Contributor

I made a small change to improve the steam visual. If we have time, or after version 1.0, we can go back and construct the stem and cloud a little differently.

image

I also added a TODO for using dt in the step() method so that the steam looks consistent across all platforms.

@chrisklus
Copy link
Contributor

chrisklus commented Feb 25, 2019

I've implemented new steam for the tea kettle using a pattern similar to the beaker's steam. Assigning to @jbphet for code review, and feedback from anyone @ariel-phet @arouinfar @jbphet.

Dev version with this change and the change in #178: https://phet-dev.colorado.edu/html/energy-forms-and-changes/1.1.0-dev.3/phet/energy-forms-and-changes_en_phet.html

I did some testing to see if this has negative performance impacts. On my machine, the tea kettle steam and beaker steam running simultaneously shows 60 FPS for the old steam and new steam. On Jemison, our slowest iPad (4th gen), the same test ran at about 9 FPS for the old steam and 10-13 for the new. Visually, the performance looks the same. I also tried out the new steam on one of our better iPads, and it was running nicely.

@arouinfar
Copy link
Contributor

@chrisklus I really like the new steam node! It looks smoother and more realistic to me.

@arouinfar arouinfar removed their assignment Feb 25, 2019
@chrisklus
Copy link
Contributor

Thanks @arouinfar!

@ariel-phet
Copy link

Looks very nice to me as well!

@ariel-phet ariel-phet removed their assignment Feb 26, 2019
@jbphet
Copy link
Contributor Author

jbphet commented Mar 7, 2019

That's a big improvement in the appearance, and the code looks great. Closing.

@jbphet jbphet closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants