Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density panel can change size slightly #375

Closed
Nancy-Salpepi opened this issue Aug 28, 2024 · 2 comments
Closed

Density panel can change size slightly #375

Nancy-Salpepi opened this issue Aug 28, 2024 · 2 comments
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.6.1

Browser
Safari 17.6

Problem description
For phetsims/qa#1136, on the Intro Screen of the Density simulation, when either block's density reaches the max value (10.00), the text gets smaller which causes the density accordion box to get smaller. This doesn't happen in published.

Steps to reproduce
Here is an example:

  1. In the Density sim, on the Intro screen, change Block A to custom
  2. Increase the Mass to max amount
  3. Move the Volume slider back and forth between min and max

Visuals

DensityPanelSize.mp4
@samreid
Copy link
Member

samreid commented Aug 29, 2024

At the given font size, the maxWidth was already shrinking things, so that accentuated the shrinking when it got the extra decimal point for 10.0. So I adjusted the font and maxWidth to try to keep it as similar as possible but without the resizing. There is a bit more boundary around the edge due to this. I tested in density intro screen. @Nancy-Salpepi can you please test on phettest?

@Nancy-Salpepi
Copy link
Author

Looks great now Sam. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants