Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to examples.md #371

Closed
Nancy-Salpepi opened this issue Aug 27, 2024 · 3 comments
Closed

Changes to examples.md #371

Nancy-Salpepi opened this issue Aug 27, 2024 · 3 comments
Assignees

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#1136

For Buoyancy Basics under Reorder the materials in the ComboBox change
buoyancyBasics.exploreScreen.view.fluidDensityPanel.comboBox.listBox

to
buoyancyBasics.exploreScreen.view.fluidPanel.comboBox.listBox

Any further changes/suggestions will also be added to this issue.

@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Aug 30, 2024

For Density, since the Volume Units are the only thing in the Simulation Tab of the Preferences Menu I would suggest changing the visible property of the the tab rather than the visible property of the volumeUnits Control.

Change:
density.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesPanels.simulationPreferencesPanel.volumeUnitsControl.visibleProperty

To:
density.general.view.navigationBar.preferencesButton.preferencesDialogCapsule.preferencesDialog.preferencesTabs.simulationTab.visibleProperty

@zepumph
Copy link
Member

zepumph commented Aug 30, 2024

@arouinfar
Copy link

Thanks @Nancy-Salpepi! I made the suggested changes in the above commits.

To address #371 (comment), I added this to the Density and Buoyancy under the 'Specify block density' section:

The Custom material behaves differently, allowing independent control of mass and volume. Its densityProperty is not a constant, and can be changed by subsequent interaction with the mass, volume, or material controls. For this reason, we recommend you first set the material to ‘Custom’ before modifying its density.

I did not add this information to Buoyancy: Basics, because customMaterial.densityProperty behaves a bit differently since it is tied to the Density slider.

Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants