Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shapes screen doesn't always reset to One Block Scene with Reset All #221

Closed
Nancy-Salpepi opened this issue Jun 17, 2024 · 4 comments
Closed

Shapes screen doesn't always reset to One Block Scene with Reset All #221

Nancy-Salpepi opened this issue Jun 17, 2024 · 4 comments
Assignees
@samreid
Labels
type:bug Something isn't working

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip and Chromebook

Operating System
14.5

Browser
Chrome

Problem description
For phetsims/qa#1095, on the Shapes Screen, with the 2 Blocks Scene selected, if I change the shape of Block B and then press Reset All, the screen will not reset to the One Block Scene.

Steps to reproduce

  1. On the Shapes Screen Select 2 Blocks Scene
  2. Change the shape of Block B
  3. Press Reset All

Visuals

sceneDoesNotReset.mp4
@Nancy-Salpepi Nancy-Salpepi added the type:bug Something isn't working label Jun 17, 2024
@samreid
Copy link
Member

samreid commented Jun 18, 2024

I'll take a look

samreid added a commit that referenced this issue Jun 18, 2024
@samreid
Reset the mode after resetting the secondaryShapeProperty, otherwise …
525805b 
…the secondary mass will become visible if it changes, see #221
@samreid
Copy link
Member

samreid commented Jun 18, 2024

Fixed, closing.

@samreid samreid closed this as completed Jun 18, 2024
@Nancy-Salpepi
Copy link
Author

I see this issue again in phetsims/qa#1136.

@Nancy-Salpepi Nancy-Salpepi reopened this Aug 23, 2024
@Nancy-Salpepi
Copy link
Author

Sorry! I was in an older dev version.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samreid @zepumph @AgustinVallejo @Nancy-Salpepi