-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan for publication with fuse #500
Comments
@samreid priority is below both of Graphing Quadratics iO and Diffraction screen |
During status meeting today, @kathy-phet requested to raise the priority. @kathy-phet said we will at a minimum need a dev version that can be shared. We checked off the 2 design questions, next steps are for me to investigate the memory and review issues. @kathy-phet also asked to be assigned to this issue to add other comments as appropriate. |
We need this version - at least a good usable dev version - for use for a class on July 15. @samreid - Can you prioritize the issues that need to be address to make it useable in class, and create a new dev version. |
@kathy-phet and @ariel-phet should I focus on circuit-construction-kit-dc for now or proceed with circuit-construction-kit-dc-virtual-lab at the same time? |
I published https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.1.0-dev.8/phet/circuit-construction-kit-dc_en_phet.html which can be used for dev testing, but will not have time to create QA dev test issue until Wednesday or Thursday. Assigning to @ariel-phet or @kathy-phet to see if they want to have someone else work on that part. UPDATE: I'm working a little today and will create a QA issue for this. |
Based on the remark in phetsims/qa#314 (comment) I'll go with both. |
I created the dev test issue, on hold until that's complete. |
Dev testing complete in phetsims/qa#361, no new issues reported. @kathy-phet you can use DC or Virtual Lab for the July 15 class: https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.1.0-dev.8/phet/circuit-construction-kit-dc_en_phet.html UPDATE: I also notified @kathy-phet over slack. |
Thanks, QA and Sam! I'll pass along the links. Does that mean this can also go to RC? |
Yes, it's ready for RC. I'll try to create the RC and set up the QA issue by end of business Friday. |
This is blocked by phetsims/chipper#764 (comment), would be good to hear from @ariel-phet or @jonathanolson before proceeding. |
phetsims/chipper#764 (comment) is no longer blocking, so I'll proceed with creating the RC. UPDATE: Deployed https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.1.0-rc.1/phet/circuit-construction-kit-dc_en_phet.html UPDATE: Deployed https://phet-dev.colorado.edu/html/circuit-construction-kit-dc-virtual-lab/1.1.0-rc.1/phet/circuit-construction-kit-dc-virtual-lab_en_phet.html UPDATE: RC issue created here: phetsims/qa#369 |
RC test revealed no new problems, I'll deploy. UPDATE: The deployment process asked me to check if the QA team credits are correct. @KatieWoe asked me to add the following: Kathryn Woessner, Ethan Ward, Jaspe Arias, and Jacob Romero @arouinfar confirmed no other changes to credits. |
I published both sims, but they haven't appeared on the website yet. Leaving self-assigned to double check later on. Also adding @arouinfar as an assignee in case any of the text descriptions need to change. UPDATE: both versions are running as 1.1.0. However the sim page "about" section still says the prior version. I don't know how we update that or if it just takes time. @arouinfar can you look into that part and consider adding some wording about the fuse, if desired. |
@samreid I think it just takes some time for the version to update, I'm seeing 1.1.0 under the About section. I've updated the Teacher Tips and sim description. Closing. |
From #463
// REVIEW
comments, see Code Review for Fuse and FuseNode #495Assigning @ariel-phet and @kathy-phet so they can help assign priority relative to Graphing Quadratics IO 1.1 and Wave Interference with Diffraction screen.
The text was updated successfully, but these errors were encountered: