Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for publication with fuse #500

Closed
9 tasks done
samreid opened this issue Jun 14, 2019 · 18 comments
Closed
9 tasks done

Plan for publication with fuse #500

samreid opened this issue Jun 14, 2019 · 18 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Jun 14, 2019

From #463

Assigning @ariel-phet and @kathy-phet so they can help assign priority relative to Graphing Quadratics IO 1.1 and Wave Interference with Diffraction screen.

@ariel-phet
Copy link

@samreid priority is below both of Graphing Quadratics iO and Diffraction screen

@samreid
Copy link
Member Author

samreid commented Jun 27, 2019

During status meeting today, @kathy-phet requested to raise the priority. @kathy-phet said we will at a minimum need a dev version that can be shared. We checked off the 2 design questions, next steps are for me to investigate the memory and review issues.

@kathy-phet also asked to be assigned to this issue to add other comments as appropriate.

@kathy-phet
Copy link

We need this version - at least a good usable dev version - for use for a class on July 15. @samreid - Can you prioritize the issues that need to be address to make it useable in class, and create a new dev version.

@samreid
Copy link
Member Author

samreid commented Jun 29, 2019

I addressed #495 and #499 and they are reassigned to @Denz1994 for review. After that we can move to dev then RC testing. I'll co-assign @Denz1994 to this issue so he is aware of priority.

@Denz1994
Copy link
Contributor

Denz1994 commented Jul 2, 2019

Issues #495 and #499 have been reviewed. Thanks for the changes @samreid. Removing assignment.

@Denz1994 Denz1994 removed their assignment Jul 2, 2019
@samreid
Copy link
Member Author

samreid commented Jul 3, 2019

We need this version - at least a good usable dev version - for use for a class on July 15.

@kathy-phet and @ariel-phet should I focus on circuit-construction-kit-dc for now or proceed with circuit-construction-kit-dc-virtual-lab at the same time?

@samreid
Copy link
Member Author

samreid commented Jul 7, 2019

I published https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.1.0-dev.8/phet/circuit-construction-kit-dc_en_phet.html which can be used for dev testing, but will not have time to create QA dev test issue until Wednesday or Thursday. Assigning to @ariel-phet or @kathy-phet to see if they want to have someone else work on that part.

UPDATE: I'm working a little today and will create a QA issue for this.

@samreid
Copy link
Member Author

samreid commented Jul 9, 2019

@kathy-phet and @ariel-phet should I focus on circuit-construction-kit-dc for now or proceed with circuit-construction-kit-dc-virtual-lab at the same time?

Based on the remark in phetsims/qa#314 (comment) I'll go with both.

@samreid
Copy link
Member Author

samreid commented Jul 9, 2019

I created the dev test issue, on hold until that's complete.

@samreid samreid removed their assignment Jul 9, 2019
@samreid
Copy link
Member Author

samreid commented Jul 10, 2019

@kathy-phet
Copy link

Thanks, QA and Sam! I'll pass along the links. Does that mean this can also go to RC?

@samreid
Copy link
Member Author

samreid commented Jul 10, 2019

Yes, it's ready for RC. I'll try to create the RC and set up the QA issue by end of business Friday.

@samreid
Copy link
Member Author

samreid commented Jul 12, 2019

This is blocked by phetsims/chipper#764 (comment), would be good to hear from @ariel-phet or @jonathanolson before proceeding.

@samreid
Copy link
Member Author

samreid commented Jul 15, 2019

@samreid
Copy link
Member Author

samreid commented Jul 25, 2019

RC test revealed no new problems, I'll deploy.

UPDATE: The deployment process asked me to check if the QA team credits are correct. @KatieWoe asked me to add the following: Kathryn Woessner, Ethan Ward, Jaspe Arias, and Jacob Romero

@arouinfar confirmed no other changes to credits.

samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Jul 26, 2019
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Jul 26, 2019
@samreid
Copy link
Member Author

samreid commented Jul 26, 2019

I published both sims, but they haven't appeared on the website yet. Leaving self-assigned to double check later on. Also adding @arouinfar as an assignee in case any of the text descriptions need to change.

UPDATE: both versions are running as 1.1.0. However the sim page "about" section still says the prior version. I don't know how we update that or if it just takes time. @arouinfar can you look into that part and consider adding some wording about the fuse, if desired.

@arouinfar
Copy link
Contributor

@samreid I think it just takes some time for the version to update, I'm seeing 1.1.0 under the About section.

I've updated the Teacher Tips and sim description. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants