-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak when disposing fuse node. #499
Comments
Same problem for resistors. Dragging out 10 resistors then pressing reset all shows 10 resistors still in memory. |
After phetsims/scenery#982, here are a collection of heap snapshots with ?fuzz in CCK-DC, taken every 30-45 seconds. |
I launched the sim with ?fuzz, then captured a memory profile, then let it run for a few minutes, then paused fuzzing via Following @Denz1994 instructions from the top comment, I still see an allocation for the first Fuse/FuseNode but after that, subsequent creation/deletion do not appear. Perhaps the first one is just some startup overhead? I followed these steps:
I saw no fuse deltas for this use case: @Denz1994 can you please review? Close if all is well. |
Thanks, @jessegreenberg for the help on this one. I'm seeing similar results after repeating @samreid test from #499 (comment). I'm going to close this one since the initial memory leak is not evident any longer in the memory profiles. |
Found during #495.
Using Chrome (incognito) I followed these steps on the Lab Screen:
Comparing the initial snapshot to the last one produced a memory increase of about 10 mb over 50 fuse disposals. Results are posted below.
Similar results were recorded for dragging the fuses into the carousel for disposal. @samreid Thought this is something worth looking into. Assigning to @samreid for further investigation.
Heap snapshot comparing initial play area with final play area after 50 disposals. Here we see a delta of +10
Fuse
and +10ResetFuseButton
objects. Note there is a duplicate 16th snapshot as a sanity check.The text was updated successfully, but these errors were encountered: