Skip to content

uvloop is now optional #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phenobarbital merged 3 commits into from
Sep 7, 2024
+12 −17
Merged

uvloop is now optional #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
525626b
removing uvloop support
phenobarbital Sep 6, 2024
b50bcba
fix some libraries
phenobarbital Sep 7, 2024
c2b7484
removing uvloop from hard dependencies
phenobarbital Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions asyncdb/drivers/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from collections.abc import Iterable
from dateutil.relativedelta import relativedelta
import asyncpg
import uvloop
from asyncpg.exceptions import (
ConnectionDoesNotExistError,
InterfaceError,
Expand Down Expand Up @@ -44,13 +43,6 @@
from asyncdb.meta.recordset import Recordset
from .sql import SQLDriver

# from .abstract import BaseCursor


asyncio.set_event_loop_policy(uvloop.EventLoopPolicy())
uvloop.install()
Comment on lines -50 to -51
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot Sep 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (performance): Explain the removal of uvloop setup for PostgreSQL driver

The removal of uvloop setup for the PostgreSQL driver could significantly impact performance. What's the rationale behind this change, and how does it align with making uvloop optional in setup.py?



class postgres(threading.Thread, SQLDriver):
_provider = "postgres"
_syntax = "sql"
Expand Down
2 changes: 1 addition & 1 deletion asyncdb/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
__title__ = "asyncdb"
__description__ = "Library for Asynchronous data source connections \
Collection of asyncio drivers."
__version__ = "2.8.4"
__version__ = "2.8.6"
__author__ = "Jesus Lara"
__author_email__ = "jesuslarag@gmail.com"
__license__ = "BSD"
19 changes: 11 additions & 8 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ def readme():
"cryptography==42.0.4",
"aiohttp>=3.9.5",
"asyncpg==0.29.0",
"uvloop==0.20.0",
"asyncio==3.4.3",
"pandas==2.2.2",
"xlrd==2.0.1",
Expand All @@ -123,7 +122,11 @@ def readme():
"aiofiles==23.2.1"
],
extras_require={
"uvloop": [
"uvloop==0.20.0"
],
"default": [
"uvloop==0.20.0",
"pylibmc==1.6.3",
"aiomcache==0.8.2",
"aiosqlite>=0.18.0",
Expand All @@ -134,18 +137,18 @@ def readme():
"pymssql==2.3.1",
"redis==5.0.8",
"deltalake==0.17.4",
"duckdb==0.10.2",
"duckdb==1.0.0",
],
"dataframe": [
"dask==2023.3.0",
"dask==2024.8.2",
'datatable==1.1.0',
"python-datatable==1.1.3",
"polars==0.20.4",
"polars==1.6.0",
"pyarrow==17.0.0",
"connectorx==0.3.3",
"pyspark==3.5.0",
"deltalake==0.17.4",
"duckdb==0.10.2",
"duckdb==1.0.0",
],
"pyspark": [
"pyspark==3.5.0"
Expand Down Expand Up @@ -242,10 +245,10 @@ def readme():
"aiokafka==0.11.0"
],
"all": [
"dask==2023.3.0",
"dask==2024.8.2",
"datatable==1.1.0",
"python-datatable==1.1.3",
"polars==0.20.4",
"polars==1.6.0",
"pyarrow==17.0.0",
"connectorx==0.3.3",
"aiosqlite>=0.18.0",
Expand Down Expand Up @@ -280,7 +283,7 @@ def readme():
"oracledb==2.2.1",
"hazelcast-python-client==5.4.0",
"deltalake==0.17.4",
"duckdb==0.10.2",
"duckdb==1.0.0",
"botocore==1.31.64",
"aiobotocore==2.7.0",
"aioboto3==12.0.0",
Expand Down