uvloop is now optional#1248
Merged
Merged
Conversation
uvloop is now optional
Contributor
Reviewer's Guide by SourceryThis pull request makes uvloop optional and updates several dependencies. The main changes include removing uvloop as a required dependency, adding it as an optional dependency, and updating versions of some packages. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @phenobarbital - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more context in the PR description. Include the rationale for making uvloop optional, mention the package version updates, and explain any potential impacts on performance or functionality.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
-50
to
-51
| asyncio.set_event_loop_policy(uvloop.EventLoopPolicy()) | ||
| uvloop.install() |
Contributor
There was a problem hiding this comment.
question (performance): Explain the removal of uvloop setup for PostgreSQL driver
The removal of uvloop setup for the PostgreSQL driver could significantly impact performance. What's the rationale behind this change, and how does it align with making uvloop optional in setup.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Make uvloop an optional dependency and update the version number to 2.8.6. Remove uvloop installation from the PostgreSQL driver.
Enhancements:
Chores: