Fix Camera rotateTo() and change destination argument #7091
+57
−124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
I started fixing #7090 and ended up changing the destination argument.
Updates (breaking change)
In Phaser 3's Camera.rotateTo(), when the
shortestPathargument wasfalse(the default value), the sign of theradiansargument indicated the direction of rotation and the absolute value of theradiansargument indicated the destination angle. In Phaser 4, theradiansargument is now calledangleand represents the destination angle as a signed value. You can use the new functionsPhaser.Math.Angle.GetClockwiseDistance()orPhaser.Math.Angle.GetCounterClockwiseDistance()to calculate rotation distances in a specific direction.Bug Fixes
rotateTo()timing is wrong #7090