Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15738 refactor helper #15740

Merged
merged 14 commits into from
Oct 26, 2021
Merged

T15738 refactor helper #15740

merged 14 commits into from
Oct 26, 2021

Conversation

niden
Copy link
Member

@niden niden commented Oct 25, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Refactored Helper classes. Moved the logic in Support\Helper and created a new factory to easily instantiate them. Increased code coverage

In the near future the Helper namespace will be deprecated

Thanks

@niden niden requested a review from Jeckerson October 25, 2021 15:34
@niden niden self-assigned this Oct 25, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request labels Oct 25, 2021
@niden niden linked an issue Oct 25, 2021 that may be closed by this pull request
[NFR]: Refactor Helper #15738
Closed
@niden niden merged commit a818a9f into phalcon:5.0.x Oct 26, 2021
@niden niden deleted the T15738-refactor-helper branch October 26, 2021 13:11
@niden niden mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Refactor Helper
2 participants
@niden @Jeckerson