Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Refactor Helper #15738

Closed
niden opened this issue Oct 24, 2021 · 1 comment · Fixed by #15740
Closed

[NFR]: Refactor Helper #15738

niden opened this issue Oct 24, 2021 · 1 comment · Fixed by #15740
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request

Comments

@niden
Copy link
Member

niden commented Oct 24, 2021 •
edited
Loading

Move Helper under Support

  • Create factory to allow easy access to helpers
  • Create one class per method
  • Remove any static calls
  • Add it to the DI
  • Testing
  • Alignment with phalcon
@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility labels Oct 24, 2021
@niden niden mentioned this issue Oct 25, 2021
Merged
5 tasks
@niden niden linked a pull request Oct 25, 2021 that will close this issue
T15738 refactor helper #15740
Merged
5 tasks
@niden
Copy link
Member Author

niden commented Oct 26, 2021

Resolved in #15740

@niden niden closed this as completed Oct 26, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

T15738 refactor helper
1 participant
@niden