Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15415 orderby interface 2 #15416

Merged
merged 4 commits into from
Apr 20, 2021
Merged

T15415 orderby interface 2 #15416

merged 4 commits into from
Apr 20, 2021

Conversation

niden
Copy link
Member

@niden niden commented Apr 20, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Corrected Phalcon\Mvc\Model\Query\BuilderInterface::orderBy to use var instead of string

Thanks

@niden niden self-assigned this Apr 20, 2021
@niden niden added 5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: medium Medium labels Apr 20, 2021
@niden niden linked an issue Apr 20, 2021 that may be closed by this pull request
[BUG]: Different types for Query\BuilderInterface::orderBy() and Query\Builder::orderBy(). #15415
Closed
@niden niden added status: high High and removed status: medium Medium labels Apr 20, 2021
@niden niden merged commit 1e7511a into phalcon:5.0.x Apr 20, 2021
@niden niden deleted the T15415-orderby-interface-2 branch April 20, 2021 20:55
@niden niden mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: high High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Different types for Query\BuilderInterface::orderBy() and Query\Builder::orderBy().
2 participants
@niden @Jeckerson