Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Logger not using Item time #15411

Closed
niden opened this issue Apr 19, 2021 · 1 comment · Fixed by #15412
Closed

[BUG]: Logger not using Item time #15411

niden opened this issue Apr 19, 2021 · 1 comment · Fixed by #15412
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework status: medium Medium

Comments

@niden
Copy link
Member

niden commented Apr 19, 2021

The Logger component does not use the Item time (entry to be logged). This is technical debt from before and the interface needs to change when creating an item.

  • Benchmarks need to be created to check whether Item (object) is more expensive than an array instead.
  • The time needs to be corrected and the timezone needs to be introduced in the adapter
  • The transactional mode of the logger has a loop with the queued items and writes each item in the loop. We need to change that to a processing cycle (for/next loop) and then one write - especially for the Stream adapter
@niden niden added bug A bug report status: unverified Unverified 5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework status: medium Medium and removed status: unverified Unverified labels Apr 19, 2021
@niden niden mentioned this issue Apr 19, 2021
5 tasks
@niden niden linked a pull request Apr 19, 2021 that will close this issue
5 tasks
@niden
Copy link
Member Author

niden commented May 1, 2021

Resolved in #15412

@niden niden closed this as completed May 1, 2021
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework status: medium Medium
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant