Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let result item still in an object #15091

Closed
wants to merge 1 commit into from
Closed

Let result item still in an object #15091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Let result item still in an object 
Item object result can give us ORM compatibility after make paging results.
  • Loading branch information
@maulanasatyaadi
maulanasatyaadi authored Jun 20, 2020
commit 743c1cece13feae4f420a7447106c2bac592f57d
3 changes: 1 addition & 2 deletions phalcon/Paginator/Adapter/Model.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ class Model extends AbstractAdapter
[modelClass, "find"],
parameters
);
let pageItems = items->toArray();
}

//Fix next
Expand All @@ -140,7 +139,7 @@ class Model extends AbstractAdapter

return this->getRepository(
[
RepositoryInterface::PROPERTY_ITEMS : pageItems,
RepositoryInterface::PROPERTY_ITEMS : items,
RepositoryInterface::PROPERTY_TOTAL_ITEMS : rowcount,
RepositoryInterface::PROPERTY_LIMIT : this->limitRows,
RepositoryInterface::PROPERTY_FIRST_PAGE : 1,
Expand Down