Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let result item still in an object #15091

Closed
wants to merge 1 commit into from

Conversation

maulanasatyaadi
Copy link

Hello!

  • Type: bug fix
  • Link to issue: #15074

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Item object result can give us ORM compatibility after make paging results.

Thanks

Item object result can give us ORM compatibility after make paging results.
@ruudboon
Copy link
Member

This will break backwards compatibility and we can't do that in 4.1. We could implement this but it should be in a backwards compatible way. Rest of @phalcon/core-team what do you guys think?

Besides that we need some tests for this.

@sergeyklay
Copy link
Contributor

I agree with @ruudboon

@maulanasatyaadi
Copy link
Author

But in Phalcon 3.4.x model adapter for paginator returns a resultset object, and that helps us to call-related model.

@Jurigag
Copy link
Contributor

Jurigag commented Jul 22, 2020

Yea but for phalcon 4 it seems it was changed. We would need to add some Model setup option i guess to add option to change this behavior, but keep old as default to avoid breaking backwards compability and add this way without returning both array and object to avoid memory usage.

@zsilbi
Copy link
Member

zsilbi commented Oct 4, 2020

Thank you @maulanasatyaadi but this breaks BC so we have to revisit this issue later.

@zsilbi zsilbi closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants