Fixed issue 14756 - File not found if path contains . #14757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on is set. I would like to make the users responsibility to not add the extension like it's described in the docs. Fixed #14756
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14757 +/- ##
==========================================
+ Coverage 67.97% 67.98% +<.01%
==========================================
Files 483 483
Lines 111435 111434 -1
==========================================
+ Hits 75752 75757 +5
+ Misses 35683 35677 -6 |
Jeckerson
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Without doing a file exists check we aren't able to detect if extension is set.
I would like to make the users responsibility to not add the extension like it's described in the docs.