Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: ConfigFactory::Load() fails if path contains dot #14756

Closed
ruudboon opened this issue Jan 22, 2020 · 1 comment
Closed

[BUG]: ConfigFactory::Load() fails if path contains dot #14756

ruudboon opened this issue Jan 22, 2020 · 1 comment
Assignees
@ruudboon
Labels
bug A bug report status: low Low

Comments

@ruudboon
Copy link
Member

If the path contains a dot the extension will not be added.

https://github.com/phalcon/cphalcon/runs/403253837#step:12:74

Expecting bug here: https://github.com/phalcon/cphalcon/blob/master/phalcon/Config/ConfigFactory.zep#L104

Phalcon 4.0.2
Php: any
@ruudboon ruudboon added bug A bug report status: unverified Unverified labels Jan 22, 2020
@ruudboon ruudboon changed the title [BUG]: ConfigFactory::Load() fails if path contains dor. [BUG]: ConfigFactory::Load() fails if path contains dot Jan 22, 2020
@ruudboon ruudboon added the 4.0.3 label Jan 22, 2020
@ruudboon ruudboon self-assigned this Jan 22, 2020
@ruudboon ruudboon mentioned this issue Jan 22, 2020
Merged
5 tasks
@niden niden added status: low Low and removed status: unverified Unverified labels Jan 22, 2020
@niden
Copy link
Member

niden commented Jan 23, 2020

Resolved in #14757 (comment)

@niden niden closed this as completed Jan 23, 2020
niden added a commit that referenced this issue Jan 23, 2020
@niden
Merge branch 'ruudboon-fix-session-issue-14694' into 4.0.x
e0c99ab 
* ruudboon-fix-session-issue-14694:
  Fixed asset
  Replaced implementation
  Missing let
  Use filepath to build correct path
  Styling fix [ci-skip]
  Updated Changelog
  Updated Changelog
  Without doing a file exists check we aren't able to detect if extension is set. I would like to make the users responsibility to not add the extension like it's described in the docs. Fixed #14756
  Fixed in storage adapter as well
  Wait for lock is removed
  Wait for lock is removed
  Lock files while writing. Fix issue #14694
niden added a commit that referenced this issue Jan 25, 2020
@niden
Merge branch '4.0.x'
d234b7b 
* 4.0.x: (61 commits)
  Optimized build files for 4.0.3
  Release 4.0.3
  Updated package to 4.0.3 and added release notes
  Bump Zephir to 0.12.16
  Fix [Source on GitHub] links
  Typos
  Change style code to camelCase
  #13655 - All tests for Annotations\Annotation
  Fixed asset
  Replaced implementation
  Missing let
  Use filepath to build correct path
  Styling fix [ci-skip]
  Updated Changelog
  Updated Changelog
  Without doing a file exists check we aren't able to detect if extension is set. I would like to make the users responsibility to not add the extension like it's described in the docs. Fixed #14756
  delete useless delete file and check if content exist in Apcu
  fix name class issu
  fix static code analytic
  #13655 - All tests done for Annotations/Adapter/* (Apcu/Memory/Stream)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruudboon ruudboon

Labels
bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niden @ruudboon