Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest for issue 14269 #14280

Closed
wants to merge 12 commits into from
Closed

Unittest for issue 14269 #14280

wants to merge 12 commits into from

Conversation

ruudboon
Copy link
Member

@ruudboon ruudboon commented Aug 4, 2019

Added unit test to test behaviour of issue #14269

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #14280 into 4.0.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14280      +/-   ##
==========================================
- Coverage    66.4%   66.39%   -0.01%     
==========================================
  Files         489      489              
  Lines      116432   116428       -4     
==========================================
- Hits        77312    77308       -4     
  Misses      39120    39120
Impacted Files Coverage Δ
ext/phalcon/session/adapter/stream.zep.c 83.16% <0%> (-0.34%) ⬇️
ext/phalcon/session/manager.zep.c 95.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a1fa2...39faadc. Read the comment docs.

Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please submit just the commits that belong to the issue, e.g. exclude session related changes?

@CameronHall
Copy link
Contributor

As discussed on Discord @ruudboon you can't use FactoryDefault to populate the DI that will not reproduce the issue in #14269.

@ruudboon ruudboon closed this Aug 7, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants