"$this->eventsManager" return null

[zuozhehao]

phalcon 4

I found that "protected event manager" would affect the magic method _get to get "eventsManager" when I did not use "setEventsManager"

cphalcon/phalcon/Di/Injectable.zep

Lines 60 to 82 in 4173bca

	* Events Manager
	*
	* @var \Phalcon\Events\ManagerInterface
	*/
	protected eventsManager;
	/**
	* Magic method __get
	*/
	public function __get(string! propertyName) -> var | null
	{
	var container, service;
	let container = <DiInterface> this->container;
	if typeof container != "object" {
	let container = Di::getDefault();
	if unlikely typeof container != "object" {
	throw new Exception(
	Exception::containerServiceNotFound("internal services")
	);
	}

[CameronHall]

In which case we will need to add the __isset magic method to catch that. @niden

[niden]

Sorry I do not understand the issue. The code is identical to v3 meaning eventsManager is protected

What are you trying to do?

[niden]

Never mind @CameronHall explained it

[CameronHall]

It's worth considering removing the eventsManager property from the DI altogether alongside the setEventsManager method altogether. Considering no one has noticed (until now) that it hasn't been an issue, there should be minimal impact (if any).

[CameronHall]

@zuozhehao can you please provide a code sample?

[zuozhehao]

class BaseController extends \Phalcon\Mvc\Controller
{

    public function afterExecuteRoute($dispatcher)
    {

        $this->eventsManager->fire('someEvent' ,$this);

    }

}

@CameronHall

[CameronHall]

@zuozhehao how do you populate your Di? With FactoryDefault?

[zuozhehao]

@CameronHall yes, Phalcon\Di\FactoryDefault

[CameronHall]

Thanks @zuozhehao I'll take a look.

[CameronHall]

@zuozhehao I've tried reproducing this but haven't be able too. After rereading through all the code, there's no reason why this shouldn't work, the only reason it wouldn't is if the the eventsManager isn't in your DI.

One thing I have noticed specifically is that the __get method of the Di can overwrite the eventsManger of the DI itself.

cphalcon/phalcon/Di/Injectable.zep

Lines 88 to 93 in 4173bca

	if container->has(propertyName) {
	let service = container->getShared(propertyName);
	let this->{propertyName} = service;
	return service;
	}

[zuozhehao]

@CameronHall
When initializing the controller, the setEventsManager was not executed,
When I used this->eventsManager, it did not go into the magic method__get

<?php

class BaseController {


    /**
     * Events Manager
     *
     * @var \Phalcon\Events\ManagerInterface
     */
    protected $eventsManager;


    /**
     * Magic method __get
     */
    public function __get($propertyName) {

        var_dump($propertyName);

    }

    /**
     * Sets the event manager
     */
    public function setEventsManager($eventsManager)
    {

        $this->eventsManager = $eventsManager;

    }

}

class IndexController extends BaseController {


    public function indexAction() {

        var_dump($this->eventsManager);

    }

}


(new IndexController)->indexAction();

[ruudboon]

@sergeyklay If you could check why this pull is failing and working in nanobox it would be great.

[niden]

This has been addressed in #14445